ZABBIX BUGS AND ISSUES

default messages for trigger, discovery and auto registration actions

Details

  • Zabbix ID:
    Reviewed 2.0

Description

Default subject and message "{TRIGGER.NAME}: {STATUS}" is good for event source "Triggers", but is of little use for "Discovery" and "Auto registration". Default messages for the last two sources should also be provided.

Activity

Hide
Aleksandrs Saveljevs added a comment -

Similarly, "{TRIGGER.NAME}: {STATUS}" is probably not the best example of a remote command.

Also, if we create a new action operation, the operation type defaults to "Send message" and "Default message" checkbox is checked. If we change the operation type to "Remote command" and to "Send message" back again, the "Default message" checkbox becomes unchecked.

Show
Aleksandrs Saveljevs added a comment - Similarly, "{TRIGGER.NAME}: {STATUS}" is probably not the best example of a remote command. Also, if we create a new action operation, the operation type defaults to "Send message" and "Default message" checkbox is checked. If we change the operation type to "Remote command" and to "Send message" back again, the "Default message" checkbox becomes unchecked.
Hide
Aleksandrs Saveljevs added a comment -

Since {STATUS} is deprecated, the default subject and message should use {TRIGGER.STATUS} instead.

Show
Aleksandrs Saveljevs added a comment - Since {STATUS} is deprecated, the default subject and message should use {TRIGGER.STATUS} instead.
Hide
richlv added a comment -

dev branch ZBX-2493-action_msg

fix the obsolete macro usage in the default action messages;
fix hardcoded message contents;
additionally, use separate contents for subject & message by introducing new define, ACTION_DEFAULT_SUBJ

one issue might be doublequote usage for the new define.

please, review =)

Show
richlv added a comment - dev branch ZBX-2493-action_msg fix the obsolete macro usage in the default action messages; fix hardcoded message contents; additionally, use separate contents for subject & message by introducing new define, ACTION_DEFAULT_SUBJ one issue might be doublequote usage for the new define. please, review =)
Hide
richlv added a comment -

obsolete macro fixed; remaining issues :

1. incorrect defaults for discovery & autoreg;
2. "default message" in operations unchecking itself

Show
richlv added a comment - obsolete macro fixed; remaining issues : 1. incorrect defaults for discovery & autoreg; 2. "default message" in operations unchecking itself
Hide
Alexey Fukalov added a comment -

dev branch: svn://svn.zabbix.com/branches/dev/ZBX-2493

Correct messages should be edited for autoreg/discovery actions, but functionality can be tested.

Show
Alexey Fukalov added a comment - dev branch: svn://svn.zabbix.com/branches/dev/ZBX-2493 Correct messages should be edited for autoreg/discovery actions, but functionality can be tested.
Hide
richlv added a comment -

possible default message for discovery (last line should be clarified once it's clear what exactly the macro returns)

subj :

Discovery of {DISCOVERY.DEVICE.IPADDRESS}: {DISCOVERY.DEVICE.STATUS}

message :

Discovery by "{DISCOVERY.RULE.NAME}" of {DISCOVERY.DEVICE.IPADDRESS}: {DISCOVERY.DEVICE.STATUS}

Discovered {DISCOVERY.SERVICE.UPTIME}

Show
richlv added a comment - possible default message for discovery (last line should be clarified once it's clear what exactly the macro returns) subj : Discovery of {DISCOVERY.DEVICE.IPADDRESS}: {DISCOVERY.DEVICE.STATUS} message : Discovery by "{DISCOVERY.RULE.NAME}" of {DISCOVERY.DEVICE.IPADDRESS}: {DISCOVERY.DEVICE.STATUS} Discovered {DISCOVERY.SERVICE.UPTIME}
Hide
richlv added a comment -

possible default message for auto-registration

1.8

subj:

Host {HOSTNAME} auto-registered

i guess message body would be the same...

trunk might be different - but it must be verified whether server will always have all this info available for notification :

subj :

Host {HOST.HOST} auto-registered

Host {HOST.HOST} registered from IP {HOST.IP} with Zabbix agent port {HOST.PORT}.

Show
richlv added a comment - possible default message for auto-registration 1.8 subj: Host {HOSTNAME} auto-registered i guess message body would be the same... trunk might be different - but it must be verified whether server will always have all this info available for notification : subj : Host {HOST.HOST} auto-registered Host {HOST.HOST} registered from IP {HOST.IP} with Zabbix agent port {HOST.PORT}.
Hide
Aleksandrs Saveljevs added a comment - - edited

(1) If we attempt to create a discovery action, then both the subject and body say "DISCOVERY". If we change action type to "Auto registration", then they both become "AUTOREG". If we change action type to "Triggers", they become the defaults for trigger actions. However, if we now change the action type to "Discovery", then the body will not change.

<asaveljevs> Also, the implemented approach is that the subject will change independently of the body. That means that if a user has changed subject, but not the body, only the body will change. Perhaps, we should look at subject and body together - change them if both are at the defaults.

<Vedmak> RESOLVED

<asaveljevs> CLOSED

Show
Aleksandrs Saveljevs added a comment - - edited (1) If we attempt to create a discovery action, then both the subject and body say "DISCOVERY". If we change action type to "Auto registration", then they both become "AUTOREG". If we change action type to "Triggers", they become the defaults for trigger actions. However, if we now change the action type to "Discovery", then the body will not change. <asaveljevs> Also, the implemented approach is that the subject will change independently of the body. That means that if a user has changed subject, but not the body, only the body will change. Perhaps, we should look at subject and body together - change them if both are at the defaults. <Vedmak> RESOLVED <asaveljevs> CLOSED
Hide
Aleksandrs Saveljevs added a comment - - edited

(2) The overriding message in an operation should also depend on the type of action. The always suggested "{TRIGGER.NAME}: {TRIGGER.STATUS}" for "Auto registration" action is not good.

<Vedmak> RESOLVED

<asaveljevs> CLOSED

Show
Aleksandrs Saveljevs added a comment - - edited (2) The overriding message in an operation should also depend on the type of action. The always suggested "{TRIGGER.NAME}: {TRIGGER.STATUS}" for "Auto registration" action is not good. <Vedmak> RESOLVED <asaveljevs> CLOSED
Hide
Igor Danoshaites added a comment -

Confirm changes in the "Default subject" and "Default message" for the Event sources= "Triggers" and "Discovery"for 1.8, BUT for the "Auto registration" event both message subject and body are "Host {HOSTNAME} auto-registered".

Show
Igor Danoshaites added a comment - Confirm changes in the "Default subject" and "Default message" for the Event sources= "Triggers" and "Discovery"for 1.8, BUT for the "Auto registration" event both message subject and body are "Host {HOSTNAME} auto-registered".
Hide
Aleksandrs Saveljevs added a comment - - edited

(3) Select "Remote command" as the type of operation. Note that the label "Default message" is visible - should not be.

<Vedmak> RESOLVED

<asaveljevs> CLOSED

Show
Aleksandrs Saveljevs added a comment - - edited (3) Select "Remote command" as the type of operation. Note that the label "Default message" is visible - should not be. <Vedmak> RESOLVED <asaveljevs> CLOSED
Hide
Aleksandrs Saveljevs added a comment - - edited

Proposal for the default subjects and messages:

===== Triggers ====

  • subject:
{TRIGGER.STATUS}: {TRIGGER.NAME}

* body (1.8):

Trigger: {TRIGGER.NAME}
Trigger status: {TRIGGER.STATUS}

Trigger severity: {TRIGGER.SEVERITY}
Trigger URL: {TRIGGER.URL}

Item values:

1. {ITEM.NAME1} ({HOSTNAME1}:{TRIGGER.KEY1}): {ITEM.VALUE1}
2. {ITEM.NAME2} ({HOSTNAME2}:{TRIGGER.KEY2}): {ITEM.VALUE2}
3. {ITEM.NAME3} ({HOSTNAME3}:{TRIGGER.KEY3}): {ITEM.VALUE3}

* body (trunk):

Trigger: {TRIGGER.NAME}
Trigger status: {TRIGGER.STATUS}
Trigger severity: {TRIGGER.SEVERITY}
Trigger URL: {TRIGGER.URL}

Item values:

1. {ITEM.NAME1} ({HOST.NAME1}:{ITEM.KEY1}): {ITEM.VALUE1}
2. {ITEM.NAME2} ({HOST.NAME2}:{ITEM.KEY2}): {ITEM.VALUE2}
3. {ITEM.NAME3} ({HOST.NAME3}:{ITEM.KEY3}): {ITEM.VALUE3}

===== Discovery =====

  • subject:

Discovery: {DISCOVERY.DEVICE.STATUS} {DISCOVERY.DEVICE.IPADDRESS}

* body (1.8):

Discovery rule: {DISCOVERY.RULE.NAME}

Device IP: {DISCOVERY.DEVICE.IPADDRESS}
Device status: {DISCOVERY.DEVICE.STATUS}
Device uptime: {DISCOVERY.DEVICE.UPTIME}

Device service name: {DISCOVERY.SERVICE.NAME}
Device service port: {DISCOVERY.SERVICE.PORT}
Device service status: {DISCOVERY.SERVICE.STATUS}
Device service uptime: {DISCOVERY.SERVICE.UPTIME}

* body (trunk):

Discovery rule: {DISCOVERY.RULE.NAME}

Device IP: {DISCOVERY.DEVICE.IPADDRESS}
Device DNS: {DISCOVERY.DEVICE.DNS}
Device status: {DISCOVERY.DEVICE.STATUS}
Device uptime: {DISCOVERY.DEVICE.UPTIME}

Device service name: {DISCOVERY.SERVICE.NAME}
Device service port: {DISCOVERY.SERVICE.PORT}
Device service status: {DISCOVERY.SERVICE.STATUS}
Device service uptime: {DISCOVERY.SERVICE.UPTIME}

===== Auto registration =====

  • subject (1.8):

Auto registration: {HOSTNAME}

* body (1.8):

Host name: {HOSTNAME}

  • subject (trunk)

Auto registration: {HOST.HOST}

* body (trunk)

Host name: {HOST.HOST}
Host IP: {HOST.IP}
Agent port: {HOST.PORT}

Show
Aleksandrs Saveljevs added a comment - - edited Proposal for the default subjects and messages: ===== Triggers ====
  • subject:
{TRIGGER.STATUS}: {TRIGGER.NAME} * body (1.8): Trigger: {TRIGGER.NAME} Trigger status: {TRIGGER.STATUS} Trigger severity: {TRIGGER.SEVERITY} Trigger URL: {TRIGGER.URL} Item values: 1. {ITEM.NAME1} ({HOSTNAME1}:{TRIGGER.KEY1}): {ITEM.VALUE1} 2. {ITEM.NAME2} ({HOSTNAME2}:{TRIGGER.KEY2}): {ITEM.VALUE2} 3. {ITEM.NAME3} ({HOSTNAME3}:{TRIGGER.KEY3}): {ITEM.VALUE3} * body (trunk): Trigger: {TRIGGER.NAME} Trigger status: {TRIGGER.STATUS} Trigger severity: {TRIGGER.SEVERITY} Trigger URL: {TRIGGER.URL} Item values: 1. {ITEM.NAME1} ({HOST.NAME1}:{ITEM.KEY1}): {ITEM.VALUE1} 2. {ITEM.NAME2} ({HOST.NAME2}:{ITEM.KEY2}): {ITEM.VALUE2} 3. {ITEM.NAME3} ({HOST.NAME3}:{ITEM.KEY3}): {ITEM.VALUE3} ===== Discovery =====
  • subject:
Discovery: {DISCOVERY.DEVICE.STATUS} {DISCOVERY.DEVICE.IPADDRESS} * body (1.8): Discovery rule: {DISCOVERY.RULE.NAME} Device IP: {DISCOVERY.DEVICE.IPADDRESS} Device status: {DISCOVERY.DEVICE.STATUS} Device uptime: {DISCOVERY.DEVICE.UPTIME} Device service name: {DISCOVERY.SERVICE.NAME} Device service port: {DISCOVERY.SERVICE.PORT} Device service status: {DISCOVERY.SERVICE.STATUS} Device service uptime: {DISCOVERY.SERVICE.UPTIME} * body (trunk): Discovery rule: {DISCOVERY.RULE.NAME} Device IP: {DISCOVERY.DEVICE.IPADDRESS} Device DNS: {DISCOVERY.DEVICE.DNS} Device status: {DISCOVERY.DEVICE.STATUS} Device uptime: {DISCOVERY.DEVICE.UPTIME} Device service name: {DISCOVERY.SERVICE.NAME} Device service port: {DISCOVERY.SERVICE.PORT} Device service status: {DISCOVERY.SERVICE.STATUS} Device service uptime: {DISCOVERY.SERVICE.UPTIME} ===== Auto registration =====
  • subject (1.8):
Auto registration: {HOSTNAME} * body (1.8): Host name: {HOSTNAME}
  • subject (trunk)
Auto registration: {HOST.HOST} * body (trunk) Host name: {HOST.HOST} Host IP: {HOST.IP} Agent port: {HOST.PORT}
Hide
Alexey Fukalov added a comment -

COMMIT: svn://svn.zabbix.com/branches/1.8 22598

Show
Alexey Fukalov added a comment - COMMIT: svn://svn.zabbix.com/branches/1.8 22598
Hide
Alexey Fukalov added a comment -

trunk dev branch: svn://svn.zabbix.com/branches/dev/ZBX-2493

Show
Alexey Fukalov added a comment - trunk dev branch: svn://svn.zabbix.com/branches/dev/ZBX-2493
Hide
Igor Danoshaites added a comment -

Confirm changes in the latest 1.8 branch.

Show
Igor Danoshaites added a comment - Confirm changes in the latest 1.8 branch.
Hide
Igor Danoshaites added a comment -

In trunk dev branch ZBX-2493 (rev #22612) all is fine, BUT when using IE8 browser several user groups can overlap each over on the screen, please see screenshot for more details. Some time ago (when I was testing maintenance periods) I also registered appropriate issue: ZBX-4244

Show
Igor Danoshaites added a comment - In trunk dev branch ZBX-2493 (rev #22612) all is fine, BUT when using IE8 browser several user groups can overlap each over on the screen, please see screenshot for more details. Some time ago (when I was testing maintenance periods) I also registered appropriate issue: ZBX-4244
Hide
Igor Danoshaites added a comment - - edited

<Igor> TESTED in both 1.8 branch and trunk

Show
Igor Danoshaites added a comment - - edited <Igor> TESTED in both 1.8 branch and trunk
Hide
Aleksandrs Saveljevs added a comment -

Trunk branch reviewed.

Show
Aleksandrs Saveljevs added a comment - Trunk branch reviewed.
Hide
Alexey Fukalov added a comment -

MERGED: svn://svn.zabbix.com/trunk 22619

Show
Alexey Fukalov added a comment - MERGED: svn://svn.zabbix.com/trunk 22619
Hide
Oleksiy Zagorskyi added a comment -

Reopened to add "1.8.9" to Fix Version/s:

Show
Oleksiy Zagorskyi added a comment - Reopened to add "1.8.9" to Fix Version/s:
Hide
Oleksiy Zagorskyi added a comment -

Closed again.

Show
Oleksiy Zagorskyi added a comment - Closed again.
Hide
Oleksiy Zagorskyi added a comment -

Really not only discovery and registration actions changed but trigger too.
Reopened to add "trigger" the issue summary because its missing can confuse sometimes.

Show
Oleksiy Zagorskyi added a comment - Really not only discovery and registration actions changed but trigger too. Reopened to add "trigger" the issue summary because its missing can confuse sometimes.
Hide
Oleksiy Zagorskyi added a comment -

Closed again.
p.s. svn commit messages are ok ("improved default messages for actions")

Show
Oleksiy Zagorskyi added a comment - Closed again. p.s. svn commit messages are ok ("improved default messages for actions")

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: