ZABBIX BUGS AND ISSUES

add xml validation for screens xml

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.8.4
  • Component/s: Frontend (F)
  • Labels:
    None
  • Zabbix ID:
    NA

Issue Links

Activity

Hide
Alexey Fukalov added a comment -
Show
Alexey Fukalov added a comment - ZBX-2690
Hide
richlv added a comment - - edited

dev branch rev 14146.

importing attached zbx_maps_export.xml results in errors :

Undefined index: images[/usr/local/apache2/htdocs/dev/ZBX-2690/include/export.inc.php:570]
Invalid argument supplied for foreach()[/usr/local/apache2/htdocs/dev/ZBX-2690/include/export.inc.php:573]
Undefined index: sysmaps[/usr/local/apache2/htdocs/dev/ZBX-2690/include/export.inc.php:614]
Invalid argument supplied for foreach()[/usr/local/apache2/htdocs/dev/ZBX-2690/include/export.inc.php:616]

Show
richlv added a comment - - edited dev branch rev 14146. importing attached zbx_maps_export.xml results in errors : Undefined index: images[/usr/local/apache2/htdocs/dev/ZBX-2690/include/export.inc.php:570] Invalid argument supplied for foreach()[/usr/local/apache2/htdocs/dev/ZBX-2690/include/export.inc.php:573] Undefined index: sysmaps[/usr/local/apache2/htdocs/dev/ZBX-2690/include/export.inc.php:614] Invalid argument supplied for foreach()[/usr/local/apache2/htdocs/dev/ZBX-2690/include/export.inc.php:616]
Hide
richlv added a comment - - edited

so we ignore map import problems for now. screen problems :

de branch rev 14153.

1. export a screen with url element, importing it fails :
Error 26: Element screenitem has extra content: url

2. importing a screen that has a map element fails :
Error 28: Datatype element resourceid has child elements

3. importing an xml with more than one screen in it fails :
Error 38: Did not expect element screen there

4. if a tag line (for example, <width>) is repeated, error message does not give line number :
Error 12: Extra element width in interleave [ Line: 0 | Column: 0 ]

5. importing an xml with "status of hostgroup triggers" element that is filtered by group fails :
Error 28: Datatype element resourceid has child elements

Show
richlv added a comment - - edited so we ignore map import problems for now. screen problems : de branch rev 14153. 1. export a screen with url element, importing it fails : Error 26: Element screenitem has extra content: url 2. importing a screen that has a map element fails : Error 28: Datatype element resourceid has child elements 3. importing an xml with more than one screen in it fails : Error 38: Did not expect element screen there 4. if a tag line (for example, <width>) is repeated, error message does not give line number : Error 12: Extra element width in interleave [ Line: 0 | Column: 0 ] 5. importing an xml with "status of hostgroup triggers" element that is filtered by group fails : Error 28: Datatype element resourceid has child elements
Hide
Alexey Fukalov added a comment -

fixed all, except 4. its library errors.. cannot do much about it

Show
Alexey Fukalov added a comment - fixed all, except 4. its library errors.. cannot do much about it
Hide
richlv added a comment -

dev branch rev 14176.

5. same is true for "Status of host triggers"

Show
richlv added a comment - dev branch rev 14176. 5. same is true for "Status of host triggers"
Hide
Alexey Fukalov added a comment -

fixed

Show
Alexey Fukalov added a comment - fixed
Hide
richlv added a comment -

dev branch rev 14205.

6. screens.rng has CRLF newlines and trailing whitespace (line 68)

other than that works fine & can be merged after fixing item 6.

Show
richlv added a comment - dev branch rev 14205. 6. screens.rng has CRLF newlines and trailing whitespace (line 68) other than that works fine & can be merged after fixing item 6.
Hide
Alexey Fukalov added a comment -

fixed

Show
Alexey Fukalov added a comment - fixed
Hide
richlv added a comment -

everything seems to be ok now

Show
richlv added a comment - everything seems to be ok now
Hide
Alexey Fukalov added a comment -

branches/1.8 14228

Show
Alexey Fukalov added a comment - branches/1.8 14228

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: