ZABBIX BUGS AND ISSUES
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-3173

server-side json parser does not handle whitespace properly

    Details

    • Type: Incident report Incident report
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.4rc1
    • Fix Version/s: 1.8.5
    • Component/s: Server (S)
    • Labels:
      None

      Description

      Consider the following JSON for file system discovery:

      {
      "vfs.fs.type.discovery":[

      { "

      {#FSNAME}":"\/", "{#FSTYPE}":"rootfs" },
      { "{#FSNAME}

      ":"\/sys", "

      {#FSTYPE}":"sysfs" },
      { "{#FSNAME}":"\/proc", "{#FSTYPE}

      ":"proc" },
      { "

      {#FSNAME}":"\/dev", "{#FSTYPE}":"devtmpfs" },
      { "{#FSNAME}

      ":"\/dev\/pts", "

      {#FSTYPE}":"devpts" },
      { "{#FSNAME}":"\/", "{#FSTYPE}

      ":"ext3" },
      { "

      {#FSNAME}":"\/lib\/init\/rw", "{#FSTYPE}":"tmpfs" },
      { "{#FSNAME}

      ":"\/dev\/shm", "

      {#FSTYPE}":"tmpfs" },
      { "{#FSNAME}":"\/home", "{#FSTYPE}

      ":"ext3" },
      { "

      {#FSNAME}":"\/tmp", "{#FSTYPE}":"ext3" },
      { "{#FSNAME}

      ":"\/usr", "

      {#FSTYPE}":"ext3" },
      { "{#FSNAME}":"\/var", "{#FSTYPE}

      ":"ext3" },
      { "

      {#FSNAME}

      ":"\/sys\/fs\/fuse\/connections", "

      {#FSTYPE}

      ":"fusectl" }

      ]
      }

      Our JSON parser requires that there is no whitespace around the colon. If there is whitespace, server says "Wrong data in JSON.", which is not a very helpful error message.

      We should improve our JSON parser so that we are more helpful to users wishing to implement their own discoveries in 2.0.

        Activity

        Aleksandrs Saveljevs created issue -
        Hide
        Aleksandrs Saveljevs added a comment -

        See http://www.json.org/ for more information on JSON.

        Show
        Aleksandrs Saveljevs added a comment - See http://www.json.org/ for more information on JSON.
        Aleksandrs Saveljevs made changes -
        Field Original Value New Value
        Assignee Aleksandrs Saveljevs [ asaveljevs ]
        Aleksandrs Saveljevs made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Aleksandrs Saveljevs added a comment -

        Made our JSON parser ignore whitespace better. Development branch: svn://svn.zabbix.com/branches/dev/ZBX-3173.

        Show
        Aleksandrs Saveljevs added a comment - Made our JSON parser ignore whitespace better. Development branch: svn://svn.zabbix.com/branches/dev/ZBX-3173.
        Aleksandrs Saveljevs made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Assignee Aleksandrs Saveljevs [ asaveljevs ] Alexander Vladishev [ sasha ]
        Fix Version/s 1.8.5 [ 10095 ]
        Resolution Fixed [ 1 ]
        Alexander Vladishev made changes -
        Status Resolved [ 5 ] Tested [ 10002 ]
        Assignee Alexander Vladishev [ sasha ] Aleksandrs Saveljevs [ asaveljevs ]
        Hide
        Aleksandrs Saveljevs added a comment -

        Available in pre-1.8.5 in r16964.

        Show
        Aleksandrs Saveljevs added a comment - Available in pre-1.8.5 in r16964.
        Aleksandrs Saveljevs made changes -
        Status Tested [ 10002 ] Closed [ 6 ]
        Aleksandrs Saveljevs made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Aleksandrs Saveljevs made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Aleksandrs Saveljevs [ asaveljevs ] Alexander Vladishev [ sasha ]
        Resolution Fixed [ 1 ]
        Alexander Vladishev made changes -
        Assignee Alexander Vladishev [ sasha ] Aleksandrs Saveljevs [ asaveljevs ]
        Aleksandrs Saveljevs made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Alexei Vladishev made changes -
        Workflow Zabbix workflow [ 19463 ] Zabbix workflow - new [ 44344 ]
        Alexander Vladishev made changes -
        Workflow Zabbix workflow - new [ 44344 ] Copy of Zabbix workflow - new [ 64369 ]
        Alexander Vladishev made changes -
        Workflow Copy of Zabbix workflow - new [ 64369 ] Zabbix workflow - new [ 79586 ]
        Gatis Rumbens made changes -
        Issue Type Bug [ 1 ] Incident report [ 10110 ]
        Zabbix ID NA
        Assignee Aleksandrs Saveljevs [ asaveljevs ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        68d 23h 9m 1 Aleksandrs Saveljevs 2011 Jan 11 08:58
        In Progress In Progress Resolved Resolved
        1d 29m 1 Aleksandrs Saveljevs 2011 Jan 12 09:28
        Resolved Resolved Merging Merging
        4d 12h 13m 1 Alexander Vladishev 2011 Jan 16 21:41
        Merging Merging Closed Closed
        14h 6m 1 Aleksandrs Saveljevs 2011 Jan 17 11:48
        Closed Closed Reopened Reopened
        3m 7s 1 Aleksandrs Saveljevs 2011 Jan 17 11:51
        Reopened Reopened Resolved Resolved
        5m 28s 1 Aleksandrs Saveljevs 2011 Jan 17 11:56
        Resolved Resolved Closed Closed
        4h 53m 1 Aleksandrs Saveljevs 2011 Jan 17 16:50

          People

          • Assignee:
            Unassigned
            Reporter:
            Aleksandrs Saveljevs
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: