ZABBIX BUGS AND ISSUES
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-4104

using closed handle in libs/zbxexec/execute.c zbx_execute()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.7
    • Fix Version/s: 1.8.9, 1.9.7 (beta)
    • Component/s: Agent (G)
    • Labels:
      None

      Description

      libs/zbxexec/execute.c zbx_execute() code, which is supposed to wait for launched process finish, is accessing previously closed handle in WaitForSingleObject() call.
      it results in sporadical false execute timeouts.

      also MSDN recommends calling SetHandleInformation() for read pipe handle for reasons unknown, and I trust them in that.

      patch for 1.8.7 is attached

      1. execute.c.patch
        0.4 kB
        alix
      2. execute.c.patch.unified
        0.8 kB
        alix

        Activity

        alix created issue -
        alix made changes -
        Field Original Value New Value
        Attachment execute.c.patch.unified [ 16664 ]
        Rudolfs Kreicbergs made changes -
        Assignee Rudolfs Kreicbergs [ stoney ]
        Rudolfs Kreicbergs made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Rudolfs Kreicbergs [ stoney ] Alexander Vladishev [ sasha ]
        Resolution Fixed [ 1 ]
        Alexei Vladishev made changes -
        Zabbix ID NA Reviewed 2.0
        dimir made changes -
        Assignee Alexander Vladishev [ sasha ] Vladimir Levijev [ dimir ]
        dimir made changes -
        Status Resolved [ 5 ] Tested [ 10002 ]
        dimir made changes -
        Assignee Vladimir Levijev [ dimir ] Rudolfs Kreicbergs [ stoney ]
        Rudolfs Kreicbergs made changes -
        Status Tested [ 10002 ] Closed [ 6 ]
        Fix Version/s 1.8.9 [ 10500 ]
        Fix Version/s 1.9.7 (trunk) [ 10502 ]
        Alexei Vladishev made changes -
        Component/s Agent (G) [ 10004 ]
        Component/s Agent (Windows) [ 10005 ]
        Alexei Vladishev made changes -
        Workflow Zabbix workflow [ 22917 ] Zabbix workflow - new [ 45163 ]

          People

          • Assignee:
            Rudolfs Kreicbergs
            Reporter:
            alix
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: