ZABBIX BUGS AND ISSUES

suffixes not properly supported in trigger testing interface in frontend

Details

Description

When trigger expression contains the suffixes in the trigger expression then tester always returns FALSE.
Example: "host:test.item.last(0)}<1G"

The last time It worked correctly in the 1.8.2.
In the 1.8.3 - 1.8.9 and current trunk it always return FALSE.

Activity

Hide
richlv added a comment - - edited

still not closed : (4) and (12)

Alexander Vladishev Reviewed and CLOSED.

Show
richlv added a comment - - edited still not closed : (4) and (12) Alexander Vladishev Reviewed and CLOSED.
Hide
richlv added a comment - - edited

(12) added unittest has not been added to SeleniumTests.php

added unittest testTriggerExpressions.php defines it's class name as being "testPageHosts" ...
<Slava> RESOLVED in r 24608

Alexander Vladishev The trigger expression parser and tests to it were completely rewritten in r31649. CLOSED

Show
richlv added a comment - - edited (12) added unittest has not been added to SeleniumTests.php added unittest testTriggerExpressions.php defines it's class name as being "testPageHosts" ... <Slava> RESOLVED in r 24608 Alexander Vladishev The trigger expression parser and tests to it were completely rewritten in r31649. CLOSED
Hide
Oleksiy Zagorskyi added a comment - - edited

(10) Missing record for the trunk ChangeLog.
1.9.9 value is missing in the "Fix Version/s:"
Will be REOPENED.
<SlaVa>
Changes for 1.8.10rc1

..F....... ZBX-4391 fixed suffix support in trigger testing interface (slava)

<zalex> I've added the tag 1.9.9 to the "Fix Version/s:"
I'm closing it. ChangeLog processing will be discussed separately.
CLOSED

Show
Oleksiy Zagorskyi added a comment - - edited (10) Missing record for the trunk ChangeLog. 1.9.9 value is missing in the "Fix Version/s:" Will be REOPENED. <SlaVa> Changes for 1.8.10rc1 ..F....... ZBX-4391 fixed suffix support in trigger testing interface (slava) <zalex> I've added the tag 1.9.9 to the "Fix Version/s:" I'm closing it. ChangeLog processing will be discussed separately. CLOSED
Hide
Vjacheslav Shipillo added a comment -

fixed in r 24449

Show
Vjacheslav Shipillo added a comment - fixed in r 24449
Hide
Alexey Fukalov added a comment - - edited

(9) [GUI]
Suffixes are left in defines.inc.php and maybe somewhere else..
<Slava>RESOLVED

<Vedmak> CLOSED

Show
Alexey Fukalov added a comment - - edited (9) [GUI] Suffixes are left in defines.inc.php and maybe somewhere else.. <Slava>RESOLVED <Vedmak> CLOSED
Hide
Alexey Fukalov added a comment - - edited

(8) [GUI]
In trunk branch all suffixes like Y, Z, etc. are still acceptable in trigger expressions, is it ok?
<SlaVa> No, it's not ok. RESOLVED r 24282

<Vedmak> CLOSED

Show
Alexey Fukalov added a comment - - edited (8) [GUI] In trunk branch all suffixes like Y, Z, etc. are still acceptable in trigger expressions, is it ok? <SlaVa> No, it's not ok. RESOLVED r 24282 <Vedmak> CLOSED
Hide
richlv added a comment - - edited

(7) new file, testTriggerExpressions.php, should have svn:eol-style svn property set to 'native'
<SlaVa>RESOLVED r 24236

<richlv> CLOSED

Show
richlv added a comment - - edited (7) new file, testTriggerExpressions.php, should have svn:eol-style svn property set to 'native' <SlaVa>RESOLVED r 24236 <richlv> CLOSED
Hide
Alexey Fukalov added a comment - - edited

(6) [GUI]
Why do you use in test both "button_click" and "click" methods?
Also formatting in test file should be fixed.
<Slava>RESOLVED r 24198

<Vedmak> CLOSED

Show
Alexey Fukalov added a comment - - edited (6) [GUI] Why do you use in test both "button_click" and "click" methods? Also formatting in test file should be fixed. <Slava>RESOLVED r 24198 <Vedmak> CLOSED
Hide
Alexey Fukalov added a comment - - edited

(5) [GUI]
In function "convert" there is still code for converting to yotta etc.
<Slava>RESOLVED r 24185

<Vedmak> CLOSED

Show
Alexey Fukalov added a comment - - edited (5) [GUI] In function "convert" there is still code for converting to yotta etc. <Slava>RESOLVED r 24185 <Vedmak> CLOSED
Hide
Vjacheslav Shipillo added a comment -

Fixed in 24150

Show
Vjacheslav Shipillo added a comment - Fixed in 24150
Hide
Alexander Vladishev added a comment - - edited

(0) is not solved

(4) a trigger expression parser on server side do not support suffixes P (Peta), E (Exa), Z (Zetta) and Y (Yotta). Please, rollback a support of these suffixes on GUI side in the trigger expressions.

<Slava> RESOLVED

Alexander Vladishev Has been fixed in ^/trunk r24449. CLOSED

Show
Alexander Vladishev added a comment - - edited (0) is not solved (4) a trigger expression parser on server side do not support suffixes P (Peta), E (Exa), Z (Zetta) and Y (Yotta). Please, rollback a support of these suffixes on GUI side in the trigger expressions. <Slava> RESOLVED Alexander Vladishev Has been fixed in ^/trunk r24449. CLOSED
Hide
Vjacheslav Shipillo added a comment - - edited

"Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4391"

<zalex> dev branch tested. works as expected.

Show
Vjacheslav Shipillo added a comment - - edited "Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4391" <zalex> dev branch tested. works as expected.
Hide
Alexey Fukalov added a comment - - edited

(3) [GUI]
I think regular expression could be simplyfied to smth like: "/([0-9\.]+)[K|M|G]?/" also case is significant, as "K" is not the same as "k"
<slava> RESOLVED
<Vedmak> in fact regexp can be simplified even more: "/[0-9\.]+[KMG]?/"
<SlaVa> RESOLVED
<Vedmak> CLOSED

Show
Alexey Fukalov added a comment - - edited (3) [GUI] I think regular expression could be simplyfied to smth like: "/([0-9\.]+)[K|M|G]?/" also case is significant, as "K" is not the same as "k" <slava> RESOLVED <Vedmak> in fact regexp can be simplified even more: "/[0-9\.]+[KMG]?/" <SlaVa> RESOLVED <Vedmak> CLOSED
Hide
Alexey Fukalov added a comment - - edited

(1) [GUI]
Not all suffixes are working (http://www.zabbix.com/documentation/1.8/manual/config/suffixes)

<slava> RESOLVED

<Vedmak> as decided we need support up to Y suffix.
<SlaVa> RESOLVED
<Vedmak> CLOSED

Show
Alexey Fukalov added a comment - - edited (1) [GUI] Not all suffixes are working (http://www.zabbix.com/documentation/1.8/manual/config/suffixes) <slava> RESOLVED <Vedmak> as decided we need support up to Y suffix. <SlaVa> RESOLVED <Vedmak> CLOSED
Hide
Vjacheslav Shipillo added a comment -

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4391

Show
Vjacheslav Shipillo added a comment - Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4391

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: