[#ZBX-4391] suffixes not properly supported in trigger testing interface in frontend - ZABBIX SUPPORT

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.8.10, 1.9.9 (beta)
Component/s: Frontend (F)
Labels:
- suffixes
- triggertesting

Description

When trigger expression contains the suffixes in the trigger expression then tester always returns FALSE.
Example: "host:test.item.last(0)}<1G"

The last time It worked correctly in the 1.8.2.
In the 1.8.3 - 1.8.9 and current trunk it always return FALSE.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Vjacheslav Shipillo added a comment - 2011 Nov 30 10:52

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4391

Show

Vjacheslav Shipillo added a comment - 2011 Nov 30 10:52 Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4391

Hide

Permalink

Alexey Fukalov added a comment - 2011 Nov 30 12:52 - edited

(1) [GUI]
Not all suffixes are working (http://www.zabbix.com/documentation/1.8/manual/config/suffixes)

<slava> RESOLVED

<Vedmak> as decided we need support up to Y suffix.
<SlaVa> RESOLVED
<Vedmak> CLOSED

Show

Alexey Fukalov added a comment - 2011 Nov 30 12:52 - edited (1) [GUI] Not all suffixes are working (http://www.zabbix.com/documentation/1.8/manual/config/suffixes) <slava> RESOLVED <Vedmak> as decided we need support up to Y suffix. <SlaVa> RESOLVED <Vedmak> CLOSED

Hide

Permalink

Alexey Fukalov added a comment - 2011 Nov 30 12:55 - edited

(3) [GUI]
I think regular expression could be simplyfied to smth like: "/([0-9\.]+)[K|M|G]?/" also case is significant, as "K" is not the same as "k"
<slava> RESOLVED
<Vedmak> in fact regexp can be simplified even more: "/[0-9\.]+[KMG]?/"
<SlaVa> RESOLVED
<Vedmak> CLOSED

Show

Alexey Fukalov added a comment - 2011 Nov 30 12:55 - edited (3) [GUI] I think regular expression could be simplyfied to smth like: "/([0-9\.]+)[K|M|G]?/" also case is significant, as "K" is not the same as "k" <slava> RESOLVED <Vedmak> in fact regexp can be simplified even more: "/[0-9\.]+[KMG]?/"

<SlaVa> RESOLVED <Vedmak> CLOSED

Hide

Permalink

Vjacheslav Shipillo added a comment - 2011 Nov 30 15:40 - edited

"Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4391"

<zalex> dev branch tested. works as expected.

Show

Vjacheslav Shipillo added a comment - 2011 Nov 30 15:40 - edited "Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4391" <zalex> dev branch tested. works as expected.

Hide

Permalink

Alexander Vladishev added a comment - 2011 Dec 15 12:26 - edited

(0) is not solved

(4) a trigger expression parser on server side do not support suffixes P (Peta), E (Exa), Z (Zetta) and Y (Yotta). Please, rollback a support of these suffixes on GUI side in the trigger expressions.

<Slava> RESOLVED

Alexander Vladishev Has been fixed in ^/trunk r24449. CLOSED

Show

Alexander Vladishev added a comment - 2011 Dec 15 12:26 - edited (0) is not solved (4) a trigger expression parser on server side do not support suffixes P (Peta), E (Exa), Z (Zetta) and Y (Yotta). Please, rollback a support of these suffixes on GUI side in the trigger expressions. <Slava> RESOLVED Alexander Vladishev Has been fixed in ^/trunk r24449. CLOSED

Hide

Permalink

Vjacheslav Shipillo added a comment - 2011 Dec 21 17:21

Fixed in 24150

Show

Vjacheslav Shipillo added a comment - 2011 Dec 21 17:21 Fixed in 24150

Hide

Permalink

Alexey Fukalov added a comment - 2011 Dec 22 16:30 - edited

(5) [GUI]
In function "convert" there is still code for converting to yotta etc.
<Slava>RESOLVED r 24185

<Vedmak> CLOSED

Show

Alexey Fukalov added a comment - 2011 Dec 22 16:30 - edited (5) [GUI] In function "convert" there is still code for converting to yotta etc. <Slava>RESOLVED r 24185 <Vedmak> CLOSED

Hide

Permalink

Alexey Fukalov added a comment - 2011 Dec 22 16:55 - edited

(6) [GUI]
Why do you use in test both "button_click" and "click" methods?
Also formatting in test file should be fixed.
<Slava>RESOLVED r 24198

<Vedmak> CLOSED

Show

Alexey Fukalov added a comment - 2011 Dec 22 16:55 - edited (6) [GUI] Why do you use in test both "button_click" and "click" methods? Also formatting in test file should be fixed. <Slava>RESOLVED r 24198 <Vedmak> CLOSED

Hide

Permalink

richlv added a comment - 2011 Dec 23 10:01 - edited

(7) new file, testTriggerExpressions.php, should have svn:eol-style svn property set to 'native'
<SlaVa>RESOLVED r 24236

<richlv> CLOSED

Show

richlv added a comment - 2011 Dec 23 10:01 - edited (7) new file, testTriggerExpressions.php, should have svn:eol-style svn property set to 'native' <SlaVa>RESOLVED r 24236 <richlv> CLOSED

Hide

Permalink

Alexey Fukalov added a comment - 2011 Dec 27 16:48 - edited

(8) [GUI]
In trunk branch all suffixes like Y, Z, etc. are still acceptable in trigger expressions, is it ok?
<SlaVa> No, it's not ok. RESOLVED r 24282

<Vedmak> CLOSED

Show

Alexey Fukalov added a comment - 2011 Dec 27 16:48 - edited (8) [GUI] In trunk branch all suffixes like Y, Z, etc. are still acceptable in trigger expressions, is it ok? <SlaVa>

No, it's not ok. RESOLVED r 24282 <Vedmak> CLOSED

Hide

Permalink

Alexey Fukalov added a comment - 2011 Dec 28 11:56 - edited

(9) [GUI]
Suffixes are left in defines.inc.php and maybe somewhere else..
<Slava>RESOLVED

<Vedmak> CLOSED

Show

Alexey Fukalov added a comment - 2011 Dec 28 11:56 - edited (9) [GUI] Suffixes are left in defines.inc.php and maybe somewhere else.. <Slava>RESOLVED <Vedmak> CLOSED

Hide

Permalink

Vjacheslav Shipillo added a comment - 2011 Dec 30 12:30

fixed in r 24449

Show

Vjacheslav Shipillo added a comment - 2011 Dec 30 12:30 fixed in r 24449

Hide

Permalink

Oleksiy Zagorskyi added a comment - 2011 Dec 30 13:02 - edited

(10) Missing record for the trunk ChangeLog.
1.9.9 value is missing in the "Fix Version/s:"
Will be REOPENED.
<SlaVa>
Changes for 1.8.10rc1

..F....... ~~ZBX-4391~~ fixed suffix support in trigger testing interface (slava)

<zalex> I've added the tag 1.9.9 to the "Fix Version/s:"
I'm closing it. ChangeLog processing will be discussed separately.
CLOSED

Show

Oleksiy Zagorskyi added a comment - 2011 Dec 30 13:02 - edited (10) Missing record for the trunk ChangeLog. 1.9.9

value is missing in the "Fix Version/s:" Will be REOPENED. <SlaVa> Changes for 1.8.10rc1 ..F....... ~~ZBX-4391~~ fixed suffix support in trigger testing interface (slava) <zalex> I've added the tag 1.9.9 to the "Fix Version/s:" I'm closing it. ChangeLog processing will be discussed separately. CLOSED

Hide

Permalink

richlv added a comment - 2012 Jan 08 13:56 - edited

(12) added unittest has not been added to SeleniumTests.php

added unittest testTriggerExpressions.php defines it's class name as being "testPageHosts" ...
<Slava> RESOLVED in r 24608

Alexander Vladishev The trigger expression parser and tests to it were completely rewritten in r31649. CLOSED

Show

richlv added a comment - 2012 Jan 08 13:56 - edited (12) added unittest has not been added to SeleniumTests.php added unittest testTriggerExpressions.php defines it's class name as being "testPageHosts" ... <Slava> RESOLVED in r 24608 Alexander Vladishev The trigger expression parser and tests to it were completely rewritten in r31649. CLOSED

Hide

Permalink

richlv added a comment - 2013 Aug 19 11:46 - edited

still not closed : (4) and (12)

Alexander Vladishev Reviewed and CLOSED.

Show

richlv added a comment - 2013 Aug 19 11:46 - edited still not closed : (4) and (12) Alexander Vladishev Reviewed and CLOSED.

People

Assignee:

Unassigned

Reporter:

Oleksiy Zagorskyi

Vote (0)

Watch (1)

Dates

Created:

2011 Nov 24 20:55

Updated:

2013 Sep 21 11:36

Resolved:

2012 Jan 09 09:19

ZABBIX BUGS AND ISSUES

suffixes not properly supported in trigger testing interface in frontend

Details

Description

Activity

People

Dates