Details

      Issue Links

        Activity

        Hide
        richlv added a comment - - edited

        (1) i believe this is the 3rd time for the same bug... unittests

        <pavels> I've added a simple create/retrieve/delete unit test for the item API, plus a special test for this case ). RESOLVED.

        Show
        richlv added a comment - - edited (1) i believe this is the 3rd time for the same bug... unittests <pavels> I've added a simple create/retrieve/delete unit test for the item API, plus a special test for this case ). RESOLVED.
        Hide
        Pavels Jelisejevs added a comment -

        RESOLVED.

        Show
        Pavels Jelisejevs added a comment - RESOLVED.
        Hide
        Alexey Fukalov added a comment - - edited

        (2) [GUI]
        Incorrect formatting of "if" statements, and some logic improvements we discussed.

        <pavels> RESOLVED.

        <Vedmak> we decided to have next line in long "ifs" to be indented with two tabs.

        <pavels> RESOLVED.

        <Vedmak> CLOSED

        Show
        Alexey Fukalov added a comment - - edited (2) [GUI] Incorrect formatting of "if" statements, and some logic improvements we discussed. <pavels> RESOLVED. <Vedmak> we decided to have next line in long "ifs" to be indented with two tabs. <pavels> RESOLVED. <Vedmak> CLOSED
        Hide
        Pavels Jelisejevs added a comment -

        Merged to trunk r24033. CLOSED.

        Show
        Pavels Jelisejevs added a comment - Merged to trunk r24033. CLOSED.
        Hide
        Alexander Vladishev added a comment - - edited

        When full-cloning a host there is a following error:
        "Item uses host interface from non-parent host."

        https://support.zabbix.com/secure/attachment/17695/cannot_add_host.jpg

        <pavels> RESOLVED in /branches/dev/ZBX-4425 r24121. This was actually broken in ZBX-3771.

        <sasha> It do not agree! It's broken in r24033. In r23994 all work fine!

        <pavels> Item prototype cloning never supported interfaces, Prior to r24033 it, probably, just haven't shown any errors =)

        <pavels> CLOSED.

        Show
        Alexander Vladishev added a comment - - edited When full-cloning a host there is a following error: "Item uses host interface from non-parent host." https://support.zabbix.com/secure/attachment/17695/cannot_add_host.jpg <pavels> RESOLVED in /branches/dev/ ZBX-4425 r24121. This was actually broken in ZBX-3771 . <sasha> It do not agree! It's broken in r24033. In r23994 all work fine! <pavels> Item prototype cloning never supported interfaces, Prior to r24033 it, probably, just haven't shown any errors =) <pavels> CLOSED.
        Hide
        Alexander Vladishev added a comment - - edited

        (1) frontends/php/api/classes/class.cdiscoveryrule.php:1080 In all places, except calculated item and trigger expressions, should be used 'Visible host name'

        <pavels> RESOLVED.
        <Sasha> TESTED Please review my changes in r24152. I have corrected some more messages.

        <pavels> CLOSED.

        Show
        Alexander Vladishev added a comment - - edited (1) frontends/php/api/classes/class.cdiscoveryrule.php:1080 In all places, except calculated item and trigger expressions, should be used 'Visible host name' <pavels> RESOLVED. <Sasha> TESTED Please review my changes in r24152. I have corrected some more messages. <pavels> CLOSED.
        Hide
        Alexander Vladishev added a comment - - edited

        (2) Please review my changes in r24136

        <pavels> CLOSED.

        Show
        Alexander Vladishev added a comment - - edited (2) Please review my changes in r24136 <pavels> CLOSED.
        Hide
        Alexander Vladishev added a comment - - edited

        Tested successfully! Please close point (1) before merge

        <pavels> There have been some conflicts when I merged the changes from trunk. Please review my commit r24156.

        <Sasha> RESOLVED I have corrected incorrectly merged changes. Please review them.

        <pavels> Thanks. CLOSED.

        Show
        Alexander Vladishev added a comment - - edited Tested successfully! Please close point (1) before merge <pavels> There have been some conflicts when I merged the changes from trunk. Please review my commit r24156. <Sasha> RESOLVED I have corrected incorrectly merged changes. Please review them. <pavels> Thanks. CLOSED.
        Hide
        Pavels Jelisejevs added a comment -

        Merged the prototype interface fix to the trunk in r24203.

        CLOSED.

        Show
        Pavels Jelisejevs added a comment - Merged the prototype interface fix to the trunk in r24203. CLOSED.
        Hide
        richlv added a comment -

        reopen to change labels

        Show
        richlv added a comment - reopen to change labels

          People

          • Assignee:
            Pavels Jelisejevs
            Reporter:
            Alexey Fukalov
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: