Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0
    • Component/s: Frontend (F)
    • Labels:

      Description

      currently discovery checks can only be created and deleted. this is cumbersome, especially with checks that can have many parameters, like snmp checks.
      discovery checks should be editable.

        Activity

        richlv created issue -
        Alexei Vladishev made changes -
        Field Original Value New Value
        Workflow jira [ 14588 ] ZBXNEXT workflow [ 21051 ]
        richlv made changes -
        Zabbix ID NA Reviewed 2.0
        Alexei Vladishev made changes -
        Component/s Frontend (F) [ 10072 ]
        Component/s GUI (configuration) [ 10080 ]
        Alexei Vladishev made changes -
        Labels trivial usability
        Assignee Alexei Vladishev [ alexei ]
        Zabbix ID Reviewed 2.0 RTD
        Alexander Vladishev made changes -
        Assignee Eduards Samersovs [ eduards ]
        Hide
        Eduards Samersovs added a comment -

        Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-109

        Show
        Eduards Samersovs added a comment - Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-109
        Eduards Samersovs made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.1.0 [ 11302 ]
        Resolution Fixed [ 1 ]
        Oleg Egorov made changes -
        Assignee Eduards Samersovs [ eduards ] Oleg Egorov [ oleg.egorov ]
        Hide
        Oleg Egorov added a comment - - edited

        (1) configuration.edit.js.php:421 line - 123 sumbols
        To resolved it, you can move

        (typeof dCheck['ports'] == 'undefined' || ZBX_CHECKLIST[dcheckid]['ports'] === dCheck['ports'])
        

        to condition begin
        Like

        				if ((typeof dCheck['ports'] == 'undefined' || ZBX_CHECKLIST[dcheckid]['ports'] === dCheck['ports'])
        						&& (typeof dCheck['type'] == 'undefined' || ZBX_CHECKLIST[dcheckid]['type'] === dCheck['type'])
        						&& (typeof dCheck['key_'] == 'undefined' || ZBX_CHECKLIST[dcheckid]['key_'] === dCheck['key_'])
        

        Eduards Samersovs RESOLVED r.34040

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited (1) configuration.edit.js.php:421 line - 123 sumbols To resolved it, you can move (typeof dCheck['ports'] == 'undefined' || ZBX_CHECKLIST[dcheckid]['ports'] === dCheck['ports']) to condition begin Like if ((typeof dCheck['ports'] == 'undefined' || ZBX_CHECKLIST[dcheckid]['ports'] === dCheck['ports']) && (typeof dCheck['type'] == 'undefined' || ZBX_CHECKLIST[dcheckid]['type'] === dCheck['type']) && (typeof dCheck['key_'] == 'undefined' || ZBX_CHECKLIST[dcheckid]['key_'] === dCheck['key_']) Eduards Samersovs RESOLVED r.34040 Oleg Egorov CLOSED
        Hide
        Oleg Egorov added a comment - - edited

        (2) FTP:23 after save is FTP(23) - it's OK, but if click "edit", then form is:
        Check type: FTP
        Port range: 21

        "Port range" is default port

        This problem exist not only for FTP

        Eduards Samersovs RESOLVED r.34039

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited (2) FTP:23 after save is FTP(23) - it's OK, but if click "edit", then form is: Check type: FTP Port range: 21 "Port range" is default port This problem exist not only for FTP Eduards Samersovs RESOLVED r.34039 Oleg Egorov CLOSED
        Hide
        Oleg Egorov added a comment - - edited

        (3)
        Check type: SNMPv1 agent
        Port range: 219
        SNMP community: 1
        SNMP OID: 2

        After save is SNMPv1 agent (219) "2" and after reopen is SNMPv1 agent (219) "2"

        But if edit it
        Check type: SNMPv1 agent
        Port range: 219
        SNMP community: 1
        SNMP OID: 0

        After save is SNMPv1 agent (219) "0", but after discovery reopen is SNMPv1 agent (219)

        Without * "0"*

        Same problem with other places if user "0", for example:
        Check type: Zabbix agent
        Port range: 219
        Key: 0

        Eduards Samersovs RESOLVED r.34057

        Oleg Egorov CLOSED

        Oleg Egorov REOPENED

        Eduards Samersovs CLOSED, Moved to ZBX-6344

        Show
        Oleg Egorov added a comment - - edited (3) Check type: SNMPv1 agent Port range: 219 SNMP community: 1 SNMP OID: 2 After save is SNMPv1 agent (219) "2" and after reopen is SNMPv1 agent (219) "2" But if edit it Check type: SNMPv1 agent Port range: 219 SNMP community: 1 SNMP OID: 0 After save is SNMPv1 agent (219) "0" , but after discovery reopen is SNMPv1 agent (219) Without * "0"* Same problem with other places if user "0", for example: Check type: Zabbix agent Port range: 219 Key: 0 Eduards Samersovs RESOLVED r.34057 Oleg Egorov CLOSED Oleg Egorov REOPENED Eduards Samersovs CLOSED, Moved to ZBX-6344
        Hide
        Oleg Egorov added a comment - - edited

        (4) After "check" update, "device uniqueness criteria" is with old data.
        Example:
        Was:
        Check type: Zabbix agent
        Port range: 219
        Key: 0

        Device uniqueness criteria:
        Zabbix agent (219)

        After update:
        Check type: Zabbix agent
        Port range: 300
        Key: 1

        Device uniqueness criteria:
        Zabbix agent (219)

        Device uniqueness criteria still Zabbix agent (219)

        Eduards Samersovs RESOLVED r.34057

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited (4) After "check" update, "device uniqueness criteria" is with old data. Example: Was: Check type: Zabbix agent Port range: 219 Key: 0 Device uniqueness criteria: Zabbix agent (219) After update: Check type: Zabbix agent Port range: 300 Key: 1 Device uniqueness criteria: Zabbix agent (219) Device uniqueness criteria still Zabbix agent (219) Eduards Samersovs RESOLVED r.34057 Oleg Egorov CLOSED
        Hide
        Oleg Egorov added a comment - - edited

        (5) I have
        Device uniqueness criteria:
        IP address
        Zabbix agent (219)

        After edit Zabbix agent (219)
        From Zabbix agent (219) to FTP (22)

        I still have

        Device uniqueness criteria:
        IP address
        Zabbix agent (219)

        Added:
        If in radio was selected Zabbix agent (219)
        After save I have device uniqueness criteria without selected item, and if it save, we have error:

        Warning. Field "Device uniqueness criteria" is mandatory.
        

        And I think it save not existing value...

        Eduards Samersovs RESOLVED r.34057

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited (5) I have Device uniqueness criteria: IP address Zabbix agent (219) After edit Zabbix agent (219) From Zabbix agent (219) to FTP (22) I still have Device uniqueness criteria: IP address Zabbix agent (219) Added: If in radio was selected Zabbix agent (219) After save I have device uniqueness criteria without selected item, and if it save, we have error: Warning. Field "Device uniqueness criteria" is mandatory. And I think it save not existing value... Eduards Samersovs RESOLVED r.34057 Oleg Egorov CLOSED
        Oleg Egorov made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Oleg Egorov [ oleg.egorov ] Eduards Samersovs [ eduards ]
        Hide
        Oleg Egorov added a comment - - edited

        (6)
        Checks: SNMPv3 agent (21)
        Security level: authPriv

        After save/update don't save:
        Authentication protocol and Authentication protocol

        Eduards Samersovs RESOLVED r.34057

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited (6) Checks: SNMPv3 agent (21) Security level: authPriv After save/update don't save: Authentication protocol and Authentication protocol Eduards Samersovs RESOLVED r.34057 Oleg Egorov CLOSED
        Eduards Samersovs made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Eduards Samersovs [ eduards ] Oleg Egorov [ oleg.egorov ]
        Resolution Fixed [ 1 ]
        Hide
        Oleg Egorov added a comment - - edited

        (7) Checks: Zabbix agent
        Port range: 161
        key: key

        Then select SNMPv1 and we have:
        Port range: 161
        SNMP OID: key

        If changed "type", then unset other values...

        Eduards Samersovs RESOLVED r.34077

        Oleg Egorov REOPENED, not resolved

        Eduards Samersovs RESOLVED r.34083

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited (7) Checks: Zabbix agent Port range: 161 key: key Then select SNMPv1 and we have: Port range: 161 SNMP OID: key If changed "type", then unset other values... Eduards Samersovs RESOLVED r.34077 Oleg Egorov REOPENED, not resolved Eduards Samersovs RESOLVED r.34083 Oleg Egorov CLOSED
        Hide
        Oleg Egorov added a comment - - edited

        (8) Create discovery rule
        I add new check, for example ftp:21
        Then "save"
        Warning. Incorrect value for field "name": cannot be empty.
        Again "save"

        ... And we now don't have check, it lost...

        Eduards Samersovs RESOLVED r.34077

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited (8) Create discovery rule I add new check, for example ftp:21 Then "save" Warning. Incorrect value for field "name": cannot be empty. Again "save" ... And we now don't have check, it lost... Eduards Samersovs RESOLVED r.34077 Oleg Egorov CLOSED
        Hide
        Oleg Egorov added a comment - - edited

        (9) Checks
        1) Create new "ICMP ping"
        2) Then "New"
        3) Then "Edit" for "ICMP ping"
        4) Then Update

        Result:
        ICMP ping
        ICMP ping

        Check duplicates...

        Eduards Samersovs RESOLVED r.34077

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited (9) Checks 1) Create new "ICMP ping" 2) Then "New" 3) Then "Edit" for "ICMP ping" 4) Then Update Result: ICMP ping ICMP ping Check duplicates... Eduards Samersovs RESOLVED r.34077 Oleg Egorov CLOSED
        Oleg Egorov made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Oleg Egorov [ oleg.egorov ] Eduards Samersovs [ eduards ]
        Eduards Samersovs made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Eduards Samersovs [ eduards ] Oleg Egorov [ oleg.egorov ]
        Resolution Fixed [ 1 ]
        Oleg Egorov made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Oleg Egorov [ oleg.egorov ] Eduards Samersovs [ eduards ]
        Hide
        Oleg Egorov added a comment - - edited

        And please, if it possible, fix "Enable" bug under this ZBXNEXT

        Eduards Samersovs RESOLVED r.34083

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited And please, if it possible, fix "Enable" bug under this ZBXNEXT Eduards Samersovs RESOLVED r.34083 Oleg Egorov CLOSED
        Hide
        Oleg Egorov added a comment - - edited

        (10) Possible set "000000000001" value for port field

        Eduards Samersovs RESOLVED r.34083

        Oleg Egorov Possible save "0 1" values, after save we have " 1"...

        And

        dCheck.ports = dCheck.ports.replace(/^[0]+/g, '');
        

        I think not a perfect solution replace "0"

        Eduards Samersovs RESOLVED r.34086

        Oleg Egorov CLOSED, open ZBX-6344

        Show
        Oleg Egorov added a comment - - edited (10) Possible set "000000000001" value for port field Eduards Samersovs RESOLVED r.34083 Oleg Egorov Possible save "0 1" values, after save we have " 1"... And dCheck.ports = dCheck.ports.replace(/^[0]+/g, ''); I think not a perfect solution replace "0" Eduards Samersovs RESOLVED r.34086 Oleg Egorov CLOSED, open ZBX-6344
        Eduards Samersovs made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Eduards Samersovs [ eduards ] Oleg Egorov [ oleg.egorov ]
        Resolution Fixed [ 1 ]
        Hide
        Oleg Egorov added a comment - - edited

        (11) Create checks FTP and Zabbix agent
        Device uniqueness criteria select Zabbix agent, remove FTP.

        And now device uniqueness criteria is IP address

        Eduards Samersovs RESOLVED r.34090, r.34093

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited (11) Create checks FTP and Zabbix agent Device uniqueness criteria select Zabbix agent, remove FTP. And now device uniqueness criteria is IP address Eduards Samersovs RESOLVED r.34090, r.34093 Oleg Egorov CLOSED
        Hide
        Oleg Egorov added a comment -

        TESTED

        Show
        Oleg Egorov added a comment - TESTED
        Oleg Egorov made changes -
        Status Resolved [ 5 ] Tested [ 10002 ]
        Assignee Oleg Egorov [ oleg.egorov ] Eduards Samersovs [ eduards ]
        Hide
        Eduards Samersovs added a comment -

        Fixed in versions pre-2.1.0 (beta) r34096

        Show
        Eduards Samersovs added a comment - Fixed in versions pre-2.1.0 (beta) r34096
        Eduards Samersovs made changes -
        Status Tested [ 10002 ] Closed [ 6 ]
        Hide
        richlv added a comment - - edited

        (12) documentation. for somebody to work on it, all changes should be summarised here

        Martins Valkovskis Documentation changes:

        Martins Valkovskis CLOSED.

        Show
        richlv added a comment - - edited (12) documentation. for somebody to work on it, all changes should be summarised here Martins Valkovskis Documentation changes: https://www.zabbix.com/documentation/2.2/manual/introduction/whatsnew220#editable_discovery_checks updated screenshots at: https://www.zabbix.com/documentation/2.2/manual/discovery/network_discovery/rule Martins Valkovskis CLOSED.
        richlv made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Eduards Samersovs made changes -
        Assignee Eduards Samersovs [ eduards ] Martins Valkovskis [ martins-v ]
        Martins Valkovskis made changes -
        Assignee Martins Valkovskis [ martins-v ] Eduards Samersovs [ eduards ]
        Eduards Samersovs made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Eduards Samersovs [ eduards ] Oleg Egorov [ oleg.egorov ]
        Resolution Fixed [ 1 ]
        Hide
        Oleg Egorov added a comment - - edited

        (14) Default value is "Disabled", but should be "Enabled"

        Eduards Samersovs RESOLVED r.34118

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited (14) Default value is "Disabled", but should be "Enabled" Eduards Samersovs RESOLVED r.34118 Oleg Egorov CLOSED
        Oleg Egorov made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Oleg Egorov [ oleg.egorov ] Eduards Samersovs [ eduards ]
        Eduards Samersovs made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Eduards Samersovs [ eduards ] Oleg Egorov [ oleg.egorov ]
        Resolution Fixed [ 1 ]
        Hide
        Oleg Egorov added a comment - - edited

        (15)
        1) Create new discovery
        2) add check Zabbix agent
        3) add check FTP
        4) select in "Device uniqueness criteria" Zabbix agent
        5) Save -> Warning. Incorrect value for field "name": cannot be empty.

        ...and Device uniqueness criteria is IP address

        Same problem in discovery edit

        Eduards Samersovs RESOLVED r.34128

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited (15) 1) Create new discovery 2) add check Zabbix agent 3) add check FTP 4) select in "Device uniqueness criteria" Zabbix agent 5) Save -> Warning. Incorrect value for field "name": cannot be empty. ...and Device uniqueness criteria is IP address Same problem in discovery edit Eduards Samersovs RESOLVED r.34128 Oleg Egorov CLOSED
        Hide
        Oleg Egorov added a comment - - edited

        REOPENED (3)

        Eduards Samersovs CLOSED, Moved to ZBX-6344

        Show
        Oleg Egorov added a comment - - edited REOPENED (3) Eduards Samersovs CLOSED, Moved to ZBX-6344
        Oleg Egorov made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Oleg Egorov [ oleg.egorov ] Eduards Samersovs [ eduards ]
        Eduards Samersovs made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Eduards Samersovs [ eduards ] Oleg Egorov [ oleg.egorov ]
        Resolution Fixed [ 1 ]
        Hide
        Oleg Egorov added a comment - - edited

        (16) "Edit" in checks now don't work.
        1) Create new discovery
        2) Add new check
        3) And try edit it

        Eduards Samersovs RESOLVED r.34130

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited (16) "Edit" in checks now don't work. 1) Create new discovery 2) Add new check 3) And try edit it Eduards Samersovs RESOLVED r.34130 Oleg Egorov CLOSED
        Hide
        Oleg Egorov added a comment - - edited

        (17) Remove don't work...

        ReferenceError: new0 is not defined
        error source line:
        [Break On This Error] 	
        
        javascript: removeDCheckRow(new0);
        

        Eduards Samersovs RESOLVED r.34130

        Oleg Egorov CLOSED

        Show
        Oleg Egorov added a comment - - edited (17) Remove don't work... ReferenceError: new0 is not defined error source line: [Break On This Error] javascript: removeDCheckRow(new0); Eduards Samersovs RESOLVED r.34130 Oleg Egorov CLOSED
        Oleg Egorov made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Oleg Egorov [ oleg.egorov ] Eduards Samersovs [ eduards ]
        Eduards Samersovs made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Eduards Samersovs [ eduards ] Oleg Egorov [ oleg.egorov ]
        Resolution Fixed [ 1 ]
        Hide
        Eduards Samersovs added a comment - - edited

        (18) Unused check fields must be cleared in DB

        Eduards Samersovs RESOLVED r.34143

        Oleg Egorov CLOSED

        Show
        Eduards Samersovs added a comment - - edited (18) Unused check fields must be cleared in DB Eduards Samersovs RESOLVED r.34143 Oleg Egorov CLOSED
        Eduards Samersovs made changes -
        Assignee Oleg Egorov [ oleg.egorov ] Eduards Samersovs [ eduards ]
        Eduards Samersovs made changes -
        Assignee Eduards Samersovs [ eduards ] Oleg Egorov [ oleg.egorov ]
        Hide
        Oleg Egorov added a comment -

        TESTED

        Show
        Oleg Egorov added a comment - TESTED
        Oleg Egorov made changes -
        Status Resolved [ 5 ] Tested [ 10002 ]
        Assignee Oleg Egorov [ oleg.egorov ] Eduards Samersovs [ eduards ]
        Hide
        Eduards Samersovs added a comment -

        Fixed in versions pre-2.1.0 (beta) r34155

        Show
        Eduards Samersovs added a comment - Fixed in versions pre-2.1.0 (beta) r34155
        Eduards Samersovs made changes -
        Status Tested [ 10002 ] Closed [ 6 ]
        Alexander Vladishev made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Hide
        Alexander Vladishev added a comment - - edited

        (18) The "dcheck" record should not be deleted for edited discovery checks.

        Eduards Samersovs Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-109

        Alexander Vladishev TESTED. Please review my changes in r35437

        Eduards Samersovs CLOSED

        Show
        Alexander Vladishev added a comment - - edited (18) The "dcheck" record should not be deleted for edited discovery checks. Eduards Samersovs Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-109 Alexander Vladishev TESTED. Please review my changes in r35437 Eduards Samersovs CLOSED
        Eduards Samersovs made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Eduards Samersovs [ eduards ] Alexander Vladishev [ sasha ]
        Resolution Fixed [ 1 ]
        Alexander Vladishev made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Alexander Vladishev [ sasha ] Eduards Samersovs [ eduards ]
        Eduards Samersovs made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Eduards Samersovs [ eduards ] Alexander Vladishev [ sasha ]
        Resolution Fixed [ 1 ]
        Alexander Vladishev made changes -
        Status Resolved [ 5 ] Tested [ 10002 ]
        Assignee Alexander Vladishev [ sasha ] Eduards Samersovs [ eduards ]
        Hide
        Eduards Samersovs added a comment -

        Fixed in versions pre-2.1.0 (beta) r.35439

        Show
        Eduards Samersovs added a comment - Fixed in versions pre-2.1.0 (beta) r.35439
        Eduards Samersovs made changes -
        Status Tested [ 10002 ] Closed [ 6 ]
        Hide
        Oleksiy Zagorskyi added a comment - - edited

        (12) is not closed -> REOPENED

        Martins Valkovskis I closed it now.

        Show
        Oleksiy Zagorskyi added a comment - - edited (12) is not closed -> REOPENED Martins Valkovskis I closed it now.
        Oleksiy Zagorskyi made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Eduards Samersovs made changes -
        Assignee Eduards Samersovs [ eduards ] Martins Valkovskis [ martins-v ]
        Alexander Vladishev made changes -
        Fix Version/s 2.1.1 [ 11506 ]
        Fix Version/s 2.1.0 [ 11302 ]
        Alexander Vladishev made changes -
        Fix Version/s 2.1.2 (trunk) [ 11704 ]
        Fix Version/s 2.1.1 [ 11506 ]
        Alexander Vladishev made changes -
        Fix Version/s 2.2.0 [ 11101 ]
        Fix Version/s 2.1.2 [ 11704 ]
        Alexander Vladishev made changes -
        Workflow ZBXNEXT workflow [ 21051 ] Zabbix workflow [ 32022 ]
        Martins Valkovskis made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Martins Valkovskis made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Alexei Vladishev made changes -
        Workflow Zabbix workflow [ 32022 ] Zabbix workflow - new [ 39404 ]

          People

          • Assignee:
            Martins Valkovskis
            Reporter:
            richlv
          • Votes:
            4 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: