ZABBIX FEATURE REQUESTS
  1. ZABBIX FEATURE REQUESTS
  2. ZBXNEXT-1128

Add support for {IPADDRESS} macro in Trigger URL

    Details

      Description

      HP SNMP agents present a "System Management Homepage" at the host's IP address, https: port 2381. It would be convenient if we could use

      {IPADDRESS}

      in a Trigger URL, then it would take us directly to the page. Triggers are templated, and mass update doesn't support Trigger URLs, so it's not practical to manually add url to each trigger.

      In other scenarios, it would be useful to support macros for the IPMI Address or HOST.CONN or HOST.DNS

      Specification

      1. zabbix-2.2.5-ZBXNEXT-1128.patch
        3 kB
        Volker Fröhlich
      2. zabbix-2.2.5-ZBXNEXT-1128-1.patch
        3 kB
        Volker Fröhlich
      3. zabbix-2.2.5-ZBXNEXT-1128-2.patch
        5 kB
        Volker Fröhlich
      4. zabbix-2.2.5-ZBXNEXT-1128-3.patch
        6 kB
        Volker Fröhlich

        Issue Links

          Activity

          Hide
          hamid sfandiari added a comment - - edited

          also we could use the address like "ssh://root@{HOST.CONN}"
          but the macros is not allowed

          Show
          hamid sfandiari added a comment - - edited also we could use the address like "ssh://root@{HOST.CONN}" but the macros is not allowed
          Hide
          Chris Warren added a comment -

          I'll second this request. I'd love to be able to avoid having to add the individual host IP in the template URL.

          Show
          Chris Warren added a comment - I'll second this request. I'd love to be able to avoid having to add the individual host IP in the template URL.
          Hide
          Isamu D added a comment -

          Please implement this.

          Show
          Isamu D added a comment - Please implement this.
          Hide
          Marc added a comment -

          ZBXNEXT-2149 asks for general macro resolution in trigger url.

          Show
          Marc added a comment - ZBXNEXT-2149 asks for general macro resolution in trigger url.
          Hide
          Volker Fröhlich added a comment -

          POC patch for ZBXNEXT-1128 in 2.2.5 (macro resolution in trigger URL)

          The resolved macros are:

          • User macros
          • Interface macros
          • Host macros
          • Item macros

          It's a frontend side implementation only!

          Show
          Volker Fröhlich added a comment - POC patch for ZBXNEXT-1128 in 2.2.5 (macro resolution in trigger URL) The resolved macros are: User macros Interface macros Host macros Item macros It's a frontend side implementation only!
          Hide
          Volker Fröhlich added a comment -

          Corrected version

          • resolveTriggerUrl() is now a class method
          Show
          Volker Fröhlich added a comment - Corrected version resolveTriggerUrl() is now a class method
          Hide
          Volker Fröhlich added a comment -

          TRIGGER.ID was no longer resolved

          Show
          Volker Fröhlich added a comment - TRIGGER.ID was no longer resolved
          Hide
          Volker Fröhlich added a comment -

          Get rid of errors on overview trigger page, due to undefined expression key

          Whether that key should be there in the first place or not, I don't know.

          Show
          Volker Fröhlich added a comment - Get rid of errors on overview trigger page, due to undefined expression key Whether that key should be there in the first place or not, I don't know.
          Hide
          Igors Homjakovs added a comment -

          Server side has been fixed in svn://svn.zabbix.com/branches/dev/ZBXNEXT-1128

          Show
          Igors Homjakovs added a comment - Server side has been fixed in svn://svn.zabbix.com/branches/dev/ZBXNEXT-1128
          Hide
          Igors Homjakovs added a comment - - edited

          (1) Frontend side has to be fixed as well

          Alexander Vladishev RESOLVED in r51942.

          Ivo Kurzemnieks CLOSED.

          Show
          Igors Homjakovs added a comment - - edited (1) Frontend side has to be fixed as well Alexander Vladishev RESOLVED in r51942. Ivo Kurzemnieks CLOSED.
          Hide
          Alexander Vladishev added a comment - - edited

          (2) Made some minor changes in r51017:51018. Please review.

          Igors Homjakovs Thank you. Looks good. CLOSED.

          Show
          Alexander Vladishev added a comment - - edited (2) Made some minor changes in r51017:51018. Please review. Igors Homjakovs Thank you. Looks good. CLOSED.
          Hide
          Alexander Vladishev added a comment - - edited

          (3) Fixed resolving of user macros in r51020. Please review.

          Igors Homjakovs Thank you. Looks good. CLOSED.

          Show
          Alexander Vladishev added a comment - - edited (3) Fixed resolving of user macros in r51020. Please review. Igors Homjakovs Thank you. Looks good. CLOSED.
          Hide
          Ivo Kurzemnieks added a comment - - edited

          (4) [F] String changes?

          Alexander Vladishev No string shanges. RESOLVED

          Ivo Kurzemnieks CLOSED.

          Show
          Ivo Kurzemnieks added a comment - - edited (4) [F] String changes? Alexander Vladishev No string shanges. RESOLVED Ivo Kurzemnieks CLOSED.
          Hide
          Ivo Kurzemnieks added a comment - - edited

          (5) [F] Sceens and slideshows with Trigger overview block in menu popup do not expand URLs.

          Alexander Vladishev RESOLVED in r52059.

          Ivo Kurzemnieks 'triggerid' was already in request. I removed duplicate and sorted fields in same order as they appear in DB. Please, see my changes in r52065

          Alexander Vladishev Thanks a lot! CLOSED

          Show
          Ivo Kurzemnieks added a comment - - edited (5) [F] Sceens and slideshows with Trigger overview block in menu popup do not expand URLs. Alexander Vladishev RESOLVED in r52059. Ivo Kurzemnieks 'triggerid' was already in request. I removed duplicate and sorted fields in same order as they appear in DB. Please, see my changes in r52065 Alexander Vladishev Thanks a lot! CLOSED
          Hide
          Ivo Kurzemnieks added a comment - - edited

          (6) [F] events.php: 741 'triggerid' is not in the output, but it is required later in popup menu helper. Please, check. We can also move 'output' to be the first option.

          Alexander Vladishev RESOLVED in r52057.

          Ivo Kurzemnieks CLOSED.

          Show
          Ivo Kurzemnieks added a comment - - edited (6) [F] events.php: 741 'triggerid' is not in the output, but it is required later in popup menu helper. Please, check. We can also move 'output' to be the first option. Alexander Vladishev RESOLVED in r52057. Ivo Kurzemnieks CLOSED.
          Hide
          Ivo Kurzemnieks added a comment - - edited

          (7) [F] Please, add a commentary for CMacrosResolverHelper::resolveTriggerUrl() that $triggers should come with already IDs in the array keys. Otherwise if we forget 'preservekeys' in API calls, it will break something.

          Alexander Vladishev RESOLVED in r52058.

          Ivo Kurzemnieks CLOSED.

          Show
          Ivo Kurzemnieks added a comment - - edited (7) [F] Please, add a commentary for CMacrosResolverHelper::resolveTriggerUrl() that $triggers should come with already IDs in the array keys. Otherwise if we forget 'preservekeys' in API calls, it will break something. Alexander Vladishev RESOLVED in r52058. Ivo Kurzemnieks CLOSED.
          Hide
          Alexander Vladishev added a comment - - edited

          (8) [S] {HOST.ID<1-9>} macros are not resolved in trigger URL

          Alexander Vladishev RESOLVED in r52060.

          Ivo Kurzemnieks Checked, looks good and works. CLOSED.

          Show
          Alexander Vladishev added a comment - - edited (8) [S] {HOST.ID<1-9>} macros are not resolved in trigger URL Alexander Vladishev RESOLVED in r52060. Ivo Kurzemnieks Checked, looks good and works. CLOSED.
          Hide
          Ivo Kurzemnieks added a comment - - edited

          TESTED,
          but don't forget to close (5) before merging.

          Show
          Ivo Kurzemnieks added a comment - - edited TESTED, but don't forget to close (5) before merging.
          Hide
          Alexander Vladishev added a comment -

          Available in pre-2.5.0 r52093.

          Show
          Alexander Vladishev added a comment - Available in pre-2.5.0 r52093.
          Hide
          Alexander Vladishev added a comment - - edited

          (9) Documentation:

          Alexander Vladishev RESOLVED

          Martins Valkovskis Reviewed. I changed the wording in 'what's new' slightly and added the info to https://www.zabbix.com/documentation/3.0/manual/config/triggers/trigger#configuration as well.

          Alexander Vladishev Thanks a lot! CLOSED

          Ivo Kurzemnieks

          REOPENED.

          Alexander Vladishev RESOLVED

          Ivo Kurzemnieks Thanks! CLOSED.

          Show
          Alexander Vladishev added a comment - - edited (9) Documentation: What's new in Zabbix 3.0.0 Macros supported by location Alexander Vladishev RESOLVED Martins Valkovskis Reviewed. I changed the wording in 'what's new' slightly and added the info to https://www.zabbix.com/documentation/3.0/manual/config/triggers/trigger#configuration as well. Alexander Vladishev Thanks a lot! CLOSED Ivo Kurzemnieks I would be great to add {HOST.ID<1-9>} information for Trigger URLs, instead of just {HOST.ID} in Macros supported by location . Specification says that Listing of supported fields and Macros used in low-level discovery shoud be updated. Maybe we should check this out too, if anything needs to be updated there. REOPENED. Alexander Vladishev RESOLVED Ivo Kurzemnieks Thanks! CLOSED.

            People

            • Assignee:
              Unassigned
              Reporter:
              Kevin Doren
            • Votes:
              7 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: