Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: Frontend (F), Server (S)
    • Labels:
      None

      Description

      Similarly to triggers that have comments and maintenances that have descriptions, items should have descriptions too.

      1. bug_14.png
        55 kB
      2. bug_15.png
        97 kB
      3. bug_2.png
        89 kB
      4. bug_3.png
        33 kB
      5. bug_4.png
        55 kB
      6. bug_5.png
        97 kB

        Activity

        Hide
        richlv added a comment -

        partially duplicates ZBXNEXT-337 and ZBX-2755

        Show
        richlv added a comment - partially duplicates ZBXNEXT-337 and ZBX-2755
        Hide
        Alexey Fukalov added a comment -

        fixed

        Show
        Alexey Fukalov added a comment - fixed
        Hide
        Aleksandrs Saveljevs added a comment -

        Available in development branch svn://svn.zabbix.com/branches/dev/zbxnext-511-item-description.

        Show
        Aleksandrs Saveljevs added a comment - Available in development branch svn://svn.zabbix.com/branches/dev/zbxnext-511-item-description.
        Hide
        Aleksandrs Saveljevs added a comment -

        Some of the changes to be made to database schema:

        • items.description => items.name
        • items.description_details => items.description (also blob => text)
        • triggers.description => triggers.name
        • triggers.comments => triggers.description (also blob => text)
        • maintenances.description: blob => text
        • media_type.description => media_type.name

        Will have to check whether other tables should be updated as well.

        Show
        Aleksandrs Saveljevs added a comment - Some of the changes to be made to database schema: items.description => items.name items.description_details => items.description (also blob => text) triggers.description => triggers.name triggers.comments => triggers.description (also blob => text) maintenances.description: blob => text media_type.description => media_type.name Will have to check whether other tables should be updated as well.
        Hide
        richlv added a comment -

        item multiplier/formula is very confusing, but it should also be taken in context of xml export, where field names sometimes can be matching, and sometimes - not

        Show
        richlv added a comment - item multiplier/formula is very confusing, but it should also be taken in context of xml export, where field names sometimes can be matching, and sometimes - not
        Hide
        Konstantin Buravcov added a comment -

        DB patches and schema committed to svn://svn.zabbix.com/branches/dev/zbxnext-511-item-description

        Show
        Konstantin Buravcov added a comment - DB patches and schema committed to svn://svn.zabbix.com/branches/dev/zbxnext-511-item-description
        Hide
        richlv added a comment -

        looks like this was never finished/merged ?

        Show
        richlv added a comment - looks like this was never finished/merged ?
        Hide
        Aleksandrs Saveljevs added a comment -

        It will have to be done once again.

        Show
        Aleksandrs Saveljevs added a comment - It will have to be done once again.
        Hide
        Alexander Vladishev added a comment - - edited

        All right, we have to finish this task.

        Here is list of things to be done:

        • the branch should probably be recreated, it is just too old
        • items.description => items.name, items.description (text)
        • add support of {ITEM.DESCRIPTION<1-9>}
        • GUI form for items should be changed (Description -> Name)
        • GUI item mass updated should be changed as well (add support for the new Description field)

        Re-naming of other table fields is out of scope.

        Show
        Alexander Vladishev added a comment - - edited All right, we have to finish this task. Here is list of things to be done: the branch should probably be recreated, it is just too old items.description => items.name, items.description (text) add support of {ITEM.DESCRIPTION<1-9>} GUI form for items should be changed (Description -> Name) GUI item mass updated should be changed as well (add support for the new Description field) Re-naming of other table fields is out of scope.
        Hide
        richlv added a comment - - edited

        (1) something to pay attention to : when attempting to create a discovery rule w/o name error message says :

        Incorrect value for field "description".

        the field is named "Name"

        <Vedmak> FIXED
        <asaveljevs> CLOSED

        Show
        richlv added a comment - - edited (1) something to pay attention to : when attempting to create a discovery rule w/o name error message says : Incorrect value for field "description". the field is named "Name" <Vedmak> FIXED <asaveljevs> CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (2) Undefined index when creating an item. The error message about item key is not helpful either. See bug_2.png.

        <Vedmak> FIXED
        <asaveljevs> CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (2) Undefined index when creating an item. The error message about item key is not helpful either. See bug_2.png. <Vedmak> FIXED <asaveljevs> CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (3) The description text area does not look good in mass update. See bug_3.png.

        <Vedmak> FIXED
        <asaveljevs> CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (3) The description text area does not look good in mass update. See bug_3.png. <Vedmak> FIXED <asaveljevs> CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (4) When saving an item prototype, description is saved as its name. See bug_4.png.

        <Vedmak> FIXED
        <asaveljevs> CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (4) When saving an item prototype, description is saved as its name. See bug_4.png. <Vedmak> FIXED <asaveljevs> CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (5) On the trigger prototype page, it shows discovery rule's description instead on name. See bug_5.png.

        <Vedmak> FIXED
        <asaveljevs> CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (5) On the trigger prototype page, it shows discovery rule's description instead on name. See bug_5.png. <Vedmak> FIXED <asaveljevs> CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (6) Saving a trigger without name complains about incorrect value for field "description".

        <Vedmak> FIXED
        <asaveljevs> CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (6) Saving a trigger without name complains about incorrect value for field "description". <Vedmak> FIXED <asaveljevs> CLOSED
        Hide
        Aleksandrs Saveljevs added a comment -

        Documented

        {ITEM.DESCRIPTION}

        and

        {ITEM.KEY}

        macros at http://www.zabbix.com/documentation/2.0/manual/appendix/macros/supported_by_location.

        Show
        Aleksandrs Saveljevs added a comment - Documented {ITEM.DESCRIPTION} and {ITEM.KEY} macros at http://www.zabbix.com/documentation/2.0/manual/appendix/macros/supported_by_location .
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (7) In trigger list, triggers that are created by low-level discovery from trigger prototypes have links to discovery rules. These links are descriptions of discovery rules, not their names.

        <Vedmak> FIXED
        <asaveljevs> CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (7) In trigger list, triggers that are created by low-level discovery from trigger prototypes have links to discovery rules. These links are descriptions of discovery rules, not their names. <Vedmak> FIXED <asaveljevs> CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (8) In "Latest data" filter it says: "Show items with description like".

        <Vedmak> FIXED
        <asaveljevs> CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (8) In "Latest data" filter it says: "Show items with description like". <Vedmak> FIXED <asaveljevs> CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (9) I propose we replace 'description_expanded' with 'name_expanded'. Similarly, variable $item_description should be renamed to $item_name. Also, $max_desc_len should be $max_name_len.

        <Vedmak> FIXED
        <asaveljevs> CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (9) I propose we replace 'description_expanded' with 'name_expanded'. Similarly, variable $item_description should be renamed to $item_name. Also, $max_desc_len should be $max_name_len. <Vedmak> FIXED <asaveljevs> CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (10) In item list, filtering by name yields "Undefined index: filter_name[/home/asaveljevs/zabbix-svn/branches/dev/ZBXNEXT-511/frontends/php/items.php:860]".

        <Vedmak> FIXED
        <asaveljevs> CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (10) In item list, filtering by name yields "Undefined index: filter_name [/home/asaveljevs/zabbix-svn/branches/dev/ZBXNEXT-511/frontends/php/items.php:860] ". <Vedmak> FIXED <asaveljevs> CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (11) Different issue, but configuration of discovered triggers can be accessed through "Triggers top 100" report.

        <Vedmak> it's not connected to this issue
        <asaveljevs> Moved to ZBX-3674. CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (11) Different issue, but configuration of discovered triggers can be accessed through "Triggers top 100" report. <Vedmak> it's not connected to this issue <asaveljevs> Moved to ZBX-3674 . CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (12) It is possible to create a trigger that references an item that does not exist.

        <Vedmak> FIXED

        <asaveljevs> Perfect. But since we started messing with invalid trigger expressions, could you please take a look at why we have an undefined index when switching trigger expression to "

        {Zabbix server: .last(0)}

        =0" (note the space in place of item key).

        <Vedmak> FIXED

        <asaveljevs> CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (12) It is possible to create a trigger that references an item that does not exist. <Vedmak> FIXED <asaveljevs> Perfect. But since we started messing with invalid trigger expressions, could you please take a look at why we have an undefined index when switching trigger expression to " {Zabbix server: .last(0)} =0" (note the space in place of item key). <Vedmak> FIXED <asaveljevs> CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (13) It is possible to create a trigger that references a discovery rule. If we then click on that discovery rule in the trigger expression, we get no permissions error.

        <Vedmak> it's not connected to this issue
        <asaveljevs> Moved to ZBX-3674. CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (13) It is possible to create a trigger that references a discovery rule. If we then click on that discovery rule in the trigger expression, we get no permissions error. <Vedmak> it's not connected to this issue <asaveljevs> Moved to ZBX-3674 . CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (14) Undefined index when accessing "Configuration" -> "Actions". See bug_14.png.

        <asaveljevs> Moved to ZBX-3678. CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (14) Undefined index when accessing "Configuration" -> "Actions". See bug_14.png. <asaveljevs> Moved to ZBX-3678 . CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (15) The popup in bar reports does not close itself when clicking on an item. See bug_15.png.

        <asaveljevs> Disregard that. This problem occurs in 1.8, too.
        <asaveljevs> Moved to ZBX-3676. CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (15) The popup in bar reports does not close itself when clicking on an item. See bug_15.png. <asaveljevs> Disregard that. This problem occurs in 1.8, too. <asaveljevs> Moved to ZBX-3676 . CLOSED
        Hide
        Alexander Vladishev added a comment -

        Server side tested.

        Show
        Alexander Vladishev added a comment - Server side tested.
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (16) [API] Should rename "description" to "name" on http://www.zabbix.com/documentation/2.0/manual/appendix/api/item/get. The examples with "description" are probably still valid, but they are not as natural anymore.

        <Vedmak> changed, but as mentioned, it was valid

        <asaveljevs> I have also renamed "description" to "name" in "sortfield" row. If you like it, please close this comment and merge the branch.

        <Vedmak> Like it, CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (16) [API] Should rename "description" to "name" on http://www.zabbix.com/documentation/2.0/manual/appendix/api/item/get . The examples with "description" are probably still valid, but they are not as natural anymore. <Vedmak> changed, but as mentioned, it was valid <asaveljevs> I have also renamed "description" to "name" in "sortfield" row. If you like it, please close this comment and merge the branch. <Vedmak> Like it, CLOSED
        Hide
        Alexey Fukalov added a comment -

        trunk 18905

        Show
        Alexey Fukalov added a comment - trunk 18905

          People

          • Assignee:
            Aleksandrs Saveljevs
            Reporter:
            Aleksandrs Saveljevs
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: