[ZBX-10015] Global housekeeper settings do not work as they should to show possible time period on graphs without data Created: 2015 Oct 28 Updated: 2019 Dec 10 |
|
Status: | Open |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Frontend (F) |
Affects Version/s: | 2.2.10, 2.4.6, 3.0.0alpha3 |
Fix Version/s: | None |
Type: | Incident report | Priority: | Trivial |
Reporter: | Oleksii Zagorskyi | Assignee: | Unassigned |
Resolution: | Unresolved | Votes: | 1 |
Labels: | graphs, housekeeper, patch, timeperiodselection | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Attachments: | show_correct_range-disallow_edit.diff | ||||
Issue Links: |
|
Description |
Here are two aspects which are related each other. In r40560 (a // override item history setting with housekeeping settings if ($config['hk_history_global']) { $real_item['history'] = $config['hk_history']; Later, in r40649 (a $trendsEnabled = $config['hk_trends_global'] ? ($config['hk_trends'] > 0) : ($item['trends'] > 0); if (!$trendsEnabled But both these changes were related to PNG images building only, but not to displaying possible time periods for selection on Grpah/SimpleGraph pages. Yes, this logic is actual for graphs which don't have history/trends data in database yet, because existing data (min(clock)) have a priority when estimating possible graph range. So now if you set an item keep history/trends settings and this item doesn't have any history/trend yet, when you open a graph with the item, you will see possible maximal period from items settings, but not globally defined. (2)
I suppose there was a logical mistake in the quote, I suppose correctly it should be like this, changed part is highlighted:
but it doesn't matter already. Note that after the initial So, for better user friendly I suggest to disallow those values editing in item configuration form if they are defined on global level. Current inconsistency may mislead when you for example perform partitioning and test then graphs building. Suggested patch fixes all issues I've described. |