[ZBX-10102] meta information update is not handled correctly for numeric log items Created: 2015 Nov 19  Updated: 2017 May 30  Resolved: 2016 Nov 08

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Proxy (P), Server (S)
Affects Version/s: 3.0.0alpha4
Fix Version/s: 3.0.0beta1

Type: Incident report Priority: Blocker
Reporter: Aleksandrs Saveljevs Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: logmonitoring, metadata, regression
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

We seem to handle "meta" information field correctly for items with value type "Log". However, after ZBX-7821, we can also have meta information updates for log[], logrt[] and eventlog[] items with numeric types, but server code was not updated to handle that in ZBX-7821.

Specification: https://www.zabbix.org/wiki/Docs/specs/ZBX-10102

 Comments   
Comment by dimir [ 2016 Jan 13 ]

Fixed in development branch: svn://svn.zabbix.com/branches/dev/ZBX-10102

Comment by Andris Zeila [ 2016 Jan 14 ]

(1) get_value() function now can optionally return vector with vmware_event_t structures, which later are copied into AGENT_RESULT structures. It would be better to return already prepared AGENT_RESULT structures:

  • easier to process, poller would have simpler code
  • vmware specific functionality would stay hidden in vmware related code
  • this functionality could be used in future to return multiple values for vmware peformance collectors (optimizing collector requests - retrieving multiple values per request)

<dimir> RESOLVED in r57656

wiper CLOSED

Comment by dimir [ 2016 Jan 15 ]

(2) ZBX-10266 will be fixed under this branch.

RESOLVED in r57671

wiper CLOSED

Comment by dimir [ 2016 Jan 15 ]

(3) Simplified AGENT_RESULT structure by removing "flags" field and using "type" field for getting information about value and meta availability and.

RESOLVED in r57669.

wiper CLOSED

Comment by Andris Zeila [ 2016 Jan 18 ]

(4) Fixes & improvements made during code review, please review r57711, r57715
RESOLVED

<dimir> CLOSED

Comment by Andris Zeila [ 2016 Jan 18 ]

(5) Added UNDEF flag setting when taking nonsupported values from history cache
RESOLVED in r57716

<dimir> CLOSED

Comment by Andris Zeila [ 2016 Jan 18 ]

(6) Allow proxy to process non log items with LOG value type
RESOLVED in r57717

<dimir> CLOSED

Comment by Andris Zeila [ 2016 Jan 18 ]

Successfully tested

Comment by dimir [ 2016 Jan 18 ]

Thanks! Please review my small change in r57737.

wiper Looks good

Comment by dimir [ 2016 Jan 18 ]

Fixed in pre-3.0.0beta1 (r57761).

Comment by dimir [ 2016 Jan 26 ]

(7) [D] Documentation:

RESOLVED

martins-v Reviewed the text, changed the word order a bit. Looks good to me now, so could be closed.

<dimir> Thanks! CLOSED

Comment by Glebs Ivanovskis (Inactive) [ 2016 Feb 26 ]

Caused ZBX-10428.

Generated at Wed Apr 24 12:50:16 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.