(1) singular and plural strings are identical:

		? _n('Cannot enable discovery rules', 'Cannot enable discovery rules', $updated)
		: _n('Cannot disable discovery rules', 'Cannot disable discovery rules', $updated);

should be:

		? _n('Cannot enable discovery rule', 'Cannot enable discovery rules', $updated)
		: _n('Cannot disable discovery rule', 'Cannot disable discovery rules', $updated);

zalex_ua RESOLVED in rev 57881.

gunarspujats CLOSED

(2) [strings, documentation]
I don't like a string:
"Catches all SNMP traps from a corresponding address that match regex. Default regex is an empty string."
Yeah, 1st part is the same as in documentation https://www.zabbix.com/documentation/3.0/manual/config/items/itemtypes/snmptrap

If I'm not familiar with the item logic, the string misleads - I can suppose that the regexp is related to the address, but not to trap's value. Singular and plural forms for nouns/verb don't help here too much.
Consider please to rewrite this phrase in both places, I'd just remove "from a corresponding address" part as it's really not required there.

2nd point is a part "Default regex is an empty string." - what does it meant? Is it enough simple and clear? No, imo !
I could mistakenly read it like - if regexp empty then catch only traps with empty values.
Also, why such a detail is missing in documentation?
So I'd replace the part by: "With empty regexp catches any trap." (I really tested it)

For "snmptrap.fallback" key and its string:
"Catches all SNMP traps that are not caught by any of the snmptrap[] items from a corresponding address of the interface."
Again, the string and description in doc are not identical, although are very similar. From doc:
"Catches all SNMP traps from a corresponding address that were not caught by any of the snmptrap[] items for that interface"
Should be identical (better one should be selected) !

I ask martins-v to share opinion here.

martins-v I like the idea of removing "from a corresponding address". It's redundant and makes the sentence ambiguous in the way that you describe.

"If regexp is unspecified, catches any trap" might be a version for the second sentence.

"Catches all SNMP traps that were not caught by any of the snmptrap[] items for that interface" would be my preferred sentence for snmptrap.fallback

zalex_ua Thanks! If there are no objections, I'd perform such changes for 3.0 doc/code only.

martins-v Sounds good to me.

zalex_ua for 3rd point I took a bit shorten sentence for code, agreed by martins-v:
"Catches all SNMP traps that were not caught by any of snmptrap[] items."
Documentation updated.
RESOLVED in rev 57881.

gunarspujats CLOSED

(3)

Checks if server is accessible by ICMP ping. 0 - ICMP ping fails. 1 - ICMP ping successful. One of zabbix_server processes performs ICMP pings once per PingerFrequency seconds.

last sentence is obviously outdated and have to be removed.
As string it has been added to PHP code in ZBXNEXT-554, so it was just a copy paste of outdated information.
Strange thing that 8 different translators didn't notice this mistake earlier
Only Korean translator skipped the wrong part, good job !

zalex_ua RESOLVED in rev 57881.

gunarspujats CLOSED

(4) Translation strings changes:

Strings added:

• Catches all SNMP traps that match regex. If regexp is unspecified, catches any trap.
• Catches all SNMP traps that were not caught by any of snmptrap[] items.
• Checks if server is accessible by ICMP ping. 0 - ICMP ping fails. 1 - ICMP ping successful.

Strings deleted:

• Catches all SNMP traps from a corresponding address that match regex. Default regex is an empty string.
• Catches all SNMP traps that are not caught by any of the snmptrap[] items from a corresponding address of the interface.
• Checks if server is accessible by ICMP ping. 0 - ICMP ping fails. 1 - ICMP ping successful. One of zabbix_server processes performs ICMP pings once per PingerFrequency seconds.

gunarspujats CLOSED

Fixed in

• pre-3.0.0beta2 (trunk) r57886