zabbix-3.0-vmware-service-get-counter-id.patch
[ZBX-10266] Uninitialized variable in VMware code reported by Coverity (CIDs 118958, 118960, 118962, 118965) Created: 2016 Jan 14 Updated: 2017 May 30 Resolved: 2016 Jan 18 |
|
| Status: | Closed |
| Project: | ZABBIX BUGS AND ISSUES |
| Component/s: | Server (S) |
| Affects Version/s: | 3.0.0beta1 |
| Fix Version/s: | 3.0.0beta1 |
| Type: | Incident report | Priority: | Trivial |
| Reporter: | Glebs Ivanovskis (Inactive) | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | codequality | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
zabbix-3.0-vmware-service-get-counter-id.patch
|
| Description |
|
In several places of /src/zabbix_server/poller/checks_simple_vmware.c and /src/zabbix_server/vmware/vmware.c we pass uninitialized counterid to zbx_vmware_service_get_counterid() (src/zabbix_server/vmware/vmware.c) where we can accidentally log it uninitialized if we fail to find respective counter and initialize counterid properly. I would suggest logging different messages (with or without counterid value) depending on ret. |
| Comments |
| Comment by dimir [ 2016 Jan 14 ] |
|
Suggested patch attached. |
| Comment by dimir [ 2016 Jan 15 ] |
|
Will be fixed in |
| Comment by dimir [ 2016 Jan 18 ] |
|
Fixed in pre-3.0.0beta1 (r57761). |