[ZBX-10360] 'fuzzytime' description on WEB UI differs from WEB's and is incorrect Created: 2016 Feb 08 Updated: 2017 May 30 Resolved: 2016 Mar 08 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Frontend (F) |
Affects Version/s: | 2.0.16, 2.2.11, 3.0.0rc1 |
Fix Version/s: | 3.0.2rc1, 3.2.0alpha1 |
Type: | Incident report | Priority: | Trivial |
Reporter: | MATSUDA Daiki | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | triggerfunctions | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Description |
The trigger function 'fuzzytime' description on WEB UI frontend differs from following WEB'S. And as I checked the source code, it is incorrect. The following description shoud be change from 'more than' to 'less than and equal' In addition, the other translations must be fixed. |
Comments |
Comment by Oleksii Zagorskyi [ 2016 Feb 08 ] |
Description for the "fuzzytime" function was always complicated for me to parse it I recall a discussion and that description in documentation was improved, maybe in Of course would be better that description in the helper and documentation are identical. |
Comment by Oleksii Zagorskyi [ 2016 Feb 08 ] |
Daiki, could you please confirm and describe that there indeed is a mistake ? Unification code and documentation it's another point. |
Comment by MATSUDA Daiki [ 2016 Feb 09 ] |
As I read document and source code again, I have mistaken. In web manual and upper 2 line (l.13546 and l.13550) means that returns 1 when abs(local time - server time) <= N seconds. Is it correct? But, in Japanese translation, it is against so returns 1 when abs(local time - server time) > N seconds. |
Comment by Oleksii Zagorskyi [ 2016 Feb 09 ] |
We need attention from kodai, please have a look to JA translations. And, martins-v, how long time people will be crying reading so logically complicated sentences ? martins-v A different, but perhaps useful way of writing this could be: zalex_ua I've tested the function one more time to make sure we are correct at this stage, and we are! |
Comment by Kodai Terashima [ 2016 Feb 09 ] |
I fixed Japanese translation in 2.0. 2.2, 2,4 and 3.0. |
Comment by Oleksii Zagorskyi [ 2016 Feb 26 ] |
(1) [Documentation] gunarspujats CLOSED |
Comment by Oleksii Zagorskyi [ 2016 Feb 26 ] |
(2)
Strings deleted:
RESOLVED in r58739 and r58878 gunarspujats CLOSED |
Comment by richlv [ 2016 Feb 29 ] |
Zalex, while 'usually' here helps, i just wanted to mention that reversing 0 and 1 is easy - for example, with the net.*.port items one might monitor a port that tends to be open, but should be closed. note that nothing to change here, just a minor clarification - and examples are always good zalex_ua Hmm, indeed we could also mention key vfs.file.time[/path/file,modify] zalex_ua added, RESOLVED gunarspujats CLOSED |
Comment by richlv [ 2016 Feb 29 ] |
(3) note that the manual says for fuzzytime() :
this can be misleading, as fuzzytime() can also be useful in other cases - for example, checking file modification times. something like the following suggested instead :
zalex_ua Good point, replaced! gunarspujats CLOSED |
Comment by Oleksii Zagorskyi [ 2016 Mar 08 ] |
Fixed in: |
Comment by Oleksii Zagorskyi [ 2016 Mar 08 ] |
Martins, please review related changes on https://www.zabbix.com/documentation/3.0/manual/appendix/triggers/functions martins-v Looks good to me. zalex_ua Thanks, replicated to 2.0, 2.2, 2.4, 3.2. CLOSED |