[ZBX-10366] vmware check doesn't work for XML depth over 256 Created: 2016 Feb 09  Updated: 2017 May 30  Resolved: 2016 Feb 18

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Server (S)
Affects Version/s: 3.0.0rc1
Fix Version/s: 2.2.12rc1, 2.4.8rc1, 3.0.1rc1, 3.2.0alpha1

Type: Incident report Priority: Blocker
Reporter: Fabio Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: vmware
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

vcenter 5.5



 Description   

vmware checks fails with error:
noname.xml:7: parser error : Excessive depth in document: 256 use XML_PARSE_HUGE option

I solved it by changing the source and recompiling vmware.c

xmlReadMemory(page.data, page.offset, ZBX_VM_NONAME_XML, NULL, XML_PARSE_HUGE)



 Comments   
Comment by Andris Zeila [ 2016 Feb 12 ]

Tests did not show any performance difference when parsing ~100MB large files, seems we can simply add XML_PARSE_HUGE option to all xmlReadMemory calls without any concern.

Comment by Andris Zeila [ 2016 Feb 12 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-10366

Comment by dimir [ 2016 Feb 17 ]

Related forum topic: https://www.zabbix.com/forum/showthread.php?t=49212

Comment by dimir [ 2016 Feb 17 ]

Successfully tested. The fix allows parsing of XML files with depth over 256.

Comment by Andris Zeila [ 2016 Feb 18 ]

Released in:

  • pre-2.2.12rc1 r58539
  • pre-2.4.8rc1 r58540
  • pre-3.0.1rc1 r58541
  • pre-3.1.0 r58542
Comment by Oleksii Zagorskyi [ 2016 Feb 29 ]

Looks like it caused regression in ZBX-10459

Generated at Sat Apr 20 06:40:48 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.