[ZBX-10435] label layout problem in action operations Created: 2016 Feb 23  Updated: 2017 May 30  Resolved: 2016 Apr 05

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 3.0.1rc1
Fix Version/s: 3.0.2rc1, 3.2.0alpha1

Type: Incident report Priority: Minor
Reporter: Aleksandrs Saveljevs Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: consistency
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File add_button_alignment.patch     PNG File add_button_with_textarea.png     PNG File incorrect_align.png     PNG File operations.png    

 Description   

Consider attached "operations.png". It can be seen that labels marked with red are aligned with the top of the corresponding element on the right. However, labels marked with blue are aligned with their bottom.

 Comments   
Comment by Pavel Amosov (Inactive) [ 2016 Mar 07 ]

Fixed in svn://svn.zabbix.com/branches/dev/ZBX-10435

Comment by Alexander Vladishev [ 2016 Mar 07 ]

(1) No translation strings changed

oleg.egorov CLOSED

Comment by Alexander Vladishev [ 2016 Mar 07 ]

(2) the label marked with red dot still aligned incorrectly

sasha RESOLVED in r59093

oleg.egorov CLOSED

Comment by Pavel Amosov (Inactive) [ 2016 Mar 08 ]

Fixed in svn://svn.zabbix.com/branches/dev/ZBX-10435
Also, field names should be put inside labels for IE compatibility

Comment by Alexander Vladishev [ 2016 Mar 14 ]

(3) In FF Add button is not aligned properly with text areas.

Patch (add_button_alignment.patch) attached. Thanks to PavelA.

sasha RESOLVED in r59094

oleg.egorov CLOSED. But added related issues is ZBX-10570

Comment by Oleg Egorov (Inactive) [ 2016 Mar 23 ]

(4)

–Undefined index: esc_step_from [actionconf.php:367 → sortOperations() in include\actions.inc.php:911]
–Undefined index: esc_step_to [actionconf.php:367 → sortOperations() in include\actions.inc.php:912]
–Undefined index: esc_period [actionconf.php:367 → sortOperations() in include\actions.inc.php:913]

In ZBX-10435 was displayed undefined index issue, but I can't reproduce it again.
Please check it.

sasha It is easy to reproduce:

  • open discovery action in a first tab;
  • open list of trigger actions in second tab;
  • update any operation in first tab

These errors is not related to this fix but will be fixed here.

sasha RESOLVED in r59131.

iivs Minor code refactoring in r59290, please review.

sasha Good idea! CLOSED

Comment by Ivo Kurzemnieks [ 2016 Apr 05 ]

TESTED,

don't forget to close (4).

Comment by Alexander Vladishev [ 2016 Apr 05 ]

Fixed in:

  • pre-3.0.2 r59294
  • pre-3.1.0 (trunk) r59295
Generated at Thu Apr 25 20:42:51 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.