[ZBX-10576] Restructure unixODBC related code Created: 2016 Mar 24 Updated: 2018 Nov 15 Resolved: 2017 Oct 18 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Installation (I), Proxy (P), Server (S) |
Affects Version/s: | 3.0.2rc1, 3.2.0alpha1 |
Fix Version/s: | 4.0.0alpha1, 4.0 (plan) |
Type: | Problem report | Priority: | Trivial |
Reporter: | Glebs Ivanovskis (Inactive) | Assignee: | Glebs Ivanovskis (Inactive) |
Resolution: | Fixed | Votes: | 4 |
Labels: | codequality, libraries, unixodbc | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Issue Links: |
|
||||||||
Epic Link: | DEV-591 | ||||||||
Team: | Team A | ||||||||
Sprint: | Sprint 15, Sprint 16, Sprint 17, Sprint 18, Sprint 19 | ||||||||
Story Points: | 3 |
Description |
Zabbix interface for unixODBC library has following flaws:
We should either
|
Comments |
Comment by Glebs Ivanovskis (Inactive) [ 2016 Apr 08 ] |
Also, unixODBC function names conflict with IBM DB2 function names which makes it impossible to run Zabbix on IBM DB2 and use ODBC checks simultaneously. Credits to constantin.oshmyan for discovering this issue. |
Comment by elham jahani [ 2016 Dec 20 ] |
also in compile zabbix 3.2 I have a problem with unixODBC |
Comment by Aleksandrs Saveljevs [ 2016 Dec 20 ] |
The above problem originally discussed at http://stackoverflow.com/questions/41236437/error-during-zabbix-3-2-compile . |
Comment by Glebs Ivanovskis (Inactive) [ 2017 Sep 08 ] |
Progress so far:
Currently I'm quite happy with src/zabbix_server/poller/checks_db.c and src/zabbix_server/odbc/odbc.h but internals of src/zabbix_server/odbc/odbc.c still need some love. Left to do:
glebs.ivanovskis Update:
Available for review and testing in development branch svn://svn.zabbix.com/branches/dev/ZBX-10576 P.S. UnixODBC call semantics have not changed, at least I had no intention to do that. Therefore such occasion can be considered a bug. |
Comment by Andrea Biscuola (Inactive) [ 2017 Oct 03 ] |
Out of the previous minor comment, I like the restructuring done. It make definitely the odbc code more navigable and understandable. I also don't see functional changes here. |
Comment by Andrea Biscuola (Inactive) [ 2017 Oct 05 ] |
Successfully tested. |
Comment by Glebs Ivanovskis (Inactive) [ 2017 Oct 05 ] |
Available in pre-4.0.0alpha1 (trunk) r73216, few compiler warnings fixed in r73225, proxy-only compilation fixed in r73306. |
Comment by Andris Zeila [ 2017 Oct 06 ] |
(7) Error when trying to build only proxy: make[3]: *** No rule to make target '../../src/zabbix_server/odbc/libzbxodbc.a', needed by 'zabbix_proxy'. Stop. glebs.ivanovskis RESOLVED in r73306. abs CLOSED |