[ZBX-10736] table header separator bleeds on the vertical border Created: 2016 May 01  Updated: 2017 May 30  Resolved: 2016 Jun 29

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 3.0.2
Fix Version/s: 3.0.4rc1, 3.2.0alpha1

Type: Incident report Priority: Trivial
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File table-header-separator.png    

 Description   

ok, this one is really minor, but still

see the very-zoomed-in screenshot. table header separator line is of a different shade of grey, and it bleeds over the vertical borders.
if it is kept in a different shade of grey, it shouldn't bleed on the vertical borders.



 Comments   
Comment by Pavel Amosov (Inactive) [ 2016 May 02 ]

I confirm this issue not only for header but for other table rows.

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-10736 .

Comment by Aleksandrs Saveljevs [ 2016 May 25 ]

(1) The fix consists of the following diff:

Index: sass/stylesheets/sass/screen.scss
===================================================================
--- sass/stylesheets/sass/screen.scss	(revision 60310)
+++ sass/stylesheets/sass/screen.scss	(working copy)
@@ -587,6 +587,7 @@
 .list-table {
 	width: 100%;
 	background-color: $ui-bg-color;
+	border-collapse: separate;
 	border: 1px solid $ui-border-color;
 
 	thead th {
@@ -674,6 +675,8 @@
 		padding: 6px 5px;
 		vertical-align: middle;
 		border-bottom: 1px solid $table-border-color;
+		border-spacing: 0;
+		border-collapse: no-collapse;
 	}
 
 	.vertical_rotation_inner {

Out of these, "border-collapse" seems to default to "separate" and "border-spacing" seems to default to 0. So the only meaningful line is "border-collapse: no-collapse". However, according to https://www.w3.org/TR/CSS2/tables.html#propdef-border-collapse, "border-collapse" does not accept "no-collapse" value.

PavelA Looks like an old piece of code from some experiments. border-collapse: separate is needed in this particular case to overwrite the css reset. Should be good now. RESOLVED in r60327

asaveljevs As discussed, r60327 does not seem to be related much to this issue and has been reverted. REOPENED.

PavelA Removed border-spacing: 0; border-collapse: no-collapse; RESOLVED in r60767

asaveljevs Looks good. CLOSED.

Comment by Aleksandrs Saveljevs [ 2016 Jun 28 ]

Fixed in pre-3.0.4rc1 r60785 and pre-3.1.0 (trunk) r60786.

Generated at Fri Mar 29 15:26:34 EET 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.