[ZBX-10825] More compact table headers Created: 2016 May 19  Updated: 2019 Feb 16  Resolved: 2016 Jun 01

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 3.0.1, 3.0.2, 3.0.3
Fix Version/s: 3.0.4rc1, 3.2.0alpha1

Type: Incident report Priority: Minor
Reporter: Pavel Amosov (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: frontend, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File calendar.png    
Issue Links:
Duplicate
is duplicated by ZBX-10453 overview header prints hostnames in u... Closed

 Description   

We can decrease the horizontal spacing in table headers and increase readability by making some adjustments to header fonts and padding.



 Comments   
Comment by Pavel Amosov (Inactive) [ 2016 May 19 ]

This is also related to ZBX-10504

Comment by Aleksandrs Saveljevs [ 2016 May 25 ]

Fixed by PavelA in development branch svn://svn.zabbix.com/branches/dev/ZBX-10825 .

Comment by Aleksandrs Saveljevs [ 2016 May 25 ]

(1) As discussed together with sasha, bold headers do not seem to be very elegant.

PavelA RESOLVED in r60335

asaveljevs As discussed, in r60439 I have reverted vertical padding in table headers to 6px. Please take a look.

PavelA Looks good. CLOSED

Comment by Aleksandrs Saveljevs [ 2016 May 31 ]

(2) Table headers in forms (e.g., custom intervals in items or action operations) are still uppercase. Let's fix them, too!

PavelA RESOLVED in r60443

asaveljevs CLOSED

Comment by Aleksandrs Saveljevs [ 2016 May 31 ]

(3) Let's also fix table headers in calendar widget (see "calendar.png"). Note how "T" for Thursday is misaligned with the column contents.

asaveljevs Calendar widget implementation in frontend is different from Pavel's original design. Will fix.

asaveljevs RESOLVED in r60451.

sasha The fix is good, but class .holiday is not defined in our css. Seems it can be removed.

REOPENED

asaveljevs Removed in r60454, although another approach would be to define that class. RESOLVED.

asaveljevs The calendar also has another bug. Suppose we initially select May 15. If we now go several months back to January without selecting a date and press "Done", we will get January 15 as the output. Do we wish to fix it?

sasha Seems "another" bug can be fixed very easy:

@@ -349,7 +349,6 @@
 	},
 
 	setDone: function() {
-		this.syncSDT();
 		this.syncBSDateBySDT();
 		this.ondateselected();
 	},

asaveljevs So it seems indeed. Committed that in r60455 along with other minor changes. RESOLVED.

sasha Looks good to me! CLOSED

Comment by Alexander Vladishev [ 2016 Jun 01 ]

Available in:

  • pre-3.0.4 r60459
  • pre-3.1.0 (trunk) r60460
Generated at Wed Apr 24 01:29:03 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.