[ZBX-10852] Zabbix agent compilation on AIX 5.2 x64 Created: 2016 May 27 Updated: 2017 May 30 Resolved: 2016 Jun 13 |
|
| Status: | Closed |
| Project: | ZABBIX BUGS AND ISSUES |
| Component/s: | Agent (G) |
| Affects Version/s: | 3.0.3 |
| Fix Version/s: | 3.0.4rc1, 3.2.0alpha1 |
| Type: | Incident report | Priority: | Critical |
| Reporter: | Alexey Pustovalov | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
AIX 5.2 x64 |
||
| Issue Links: |
|
||||
| Description |
"proc.c", line 187.92: 1506-022 (S) "pi_data_l2psize" is not a member of "struct procentry64". "proc.c", line 188.95: 1506-022 (S) "pi_text_l2psize" is not a member of "struct procentry64". "proc.c", line 196.90: 1506-022 (S) "pi_data_l2psize" is not a member of "struct procentry64". "proc.c", line 209.91: 1506-022 (S) "pi_data_l2psize" is not a member of "struct procentry64". "proc.c", line 212.91: 1506-022 (S) "pi_text_l2psize" is not a member of "struct procentry64". make: 1254-004 The error code from the last command is 1. |
| Comments |
| Comment by Andris Zeila [ 2016 May 30 ] |
|
Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-10852 |
| Comment by Sandis Neilands (Inactive) [ 2016 Jun 06 ] |
|
(1) We should undefine macros at the end of the function that we intend to have only function scope. wiper RESOLVED in r60561 sandis.neilands CLOSED. |
| Comment by Sandis Neilands (Inactive) [ 2016 Jun 06 ] |
|
(2) Is pi_data_l2psize available only in AIX 6.1 or also in later AIX releases? We should hardcode the page size only when the field is not available (5.2, 5.3). An alternative could be to check for this in configuration script as is done for some other fields however considering that older AIX releases have reached end-of-life the current solution is fine. wiper There is not much information around, but on AIX 6.1 there are also defines for 5.2 and 5.3. So I assume the later AIX versions will have defines for earlier versions. |
| Comment by Sandis Neilands (Inactive) [ 2016 Jun 06 ] |
|
(3) It would be better to define a constant or macro for page size rather than use integer literal 12 (x << 12 == pages * page_size). wiper I added comments explainig the ZBX_L2PSIZE define. sandis.neilands CLOSED. |
| Comment by Sandis Neilands (Inactive) [ 2016 Jun 08 ] |
|
Tested on AIX 6.1 only (the agent still compiles and works there) due to unavailability of AIX 5.2, AIX 5.3. According to IBM support for AIX 5.3 ended in 2012. |
| Comment by Andris Zeila [ 2016 Jun 13 ] |
|
Released in:
|