[ZBX-11050] fix grammar in strings like "Triggers status" Created: 2016 Aug 02 Updated: 2017 May 30 Resolved: 2016 Sep 16 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Frontend (F) |
Affects Version/s: | 3.0.4 |
Fix Version/s: | 3.2.0alpha2, 3.2.0rc1, 3.2.1rc1, 3.4.0alpha1 |
Type: | Incident report | Priority: | Minor |
Reporter: | Aleksandrs Saveljevs | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | typo | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Issue Links: |
|
Description |
We have strings in Zabbix frontend that are not entirely correct, like "Triggers status" in "Monitoring" -> "Triggers", which should be replaced with "Trigger status" (also spotted earlier in ZBXNEXT-892). Here is a list of other strings that have been spotted:
The last three appear in screen cell configuration. |
Comments |
Comment by Aleksandrs Saveljevs [ 2016 Aug 02 ] |
Note that the fix has to be done not only in Zabbix frontend, but also in *.po files to reduce additional work required by translators and because translations are likely to be correct. zalex_ua Do NOT do that anymore please, because your efforts will be unnoticed and later lost! Because all translations are handled in Pootle only. Imagine that you did such change in SVN but translator did translate/fix other strings in Pootle ... |
Comment by richlv [ 2016 Aug 02 ] |
ooh-ooh - as this is against 3.0, there's also my favourite (fixed in trunk already) :
|
Comment by Alexei Vladishev [ 2016 Aug 02 ] |
Also the header "Status of triggers" should be replaced by "Triggers" under Monitoring->Triggers. |
Comment by Alexander Vladishev [ 2016 Aug 03 ] |
Also form header "Alarm acknowledgements" should be replaced by "Event acknowledgements". Related issue: martins-v, what do you think? martins-v I agree to this. |
Comment by vitalijs.cemeris (Inactive) [ 2016 Aug 04 ] |
(1) Translation strings Strings changed:
sasha CLOSED vitalijs.cemeris REOPENED
iivs CLOSED vitalijs.cemeris REOPENED
oleg.egorov CLOSED |
Comment by vitalijs.cemeris (Inactive) [ 2016 Aug 04 ] |
Fixed in the development branch svn://svn.zabbix.com/branches/dev/ZBX-11050 Translation strings marked in blue color was updated in .po files so that existing translations are not lost. |
Comment by Alexander Vladishev [ 2016 Aug 10 ] |
Have a look at my changes in r61571. |
Comment by vitalijs.cemeris (Inactive) [ 2016 Aug 11 ] |
Fixed in pre-3.2.0alpha2 r61572 |
Comment by vitalijs.cemeris (Inactive) [ 2016 Aug 11 ] |
(2) [D] Some images should be updated:
martins-v RESOLVED iivs Updated non-visual text in RESOLVED martins-v CLOSED |
Comment by Martins Valkovskis [ 2016 Aug 15 ] |
(3) "Enable event acknowledges" in Administration -> General is another string that should be fixed. Should be replaced by "Enable event acknowledgement". Also: "Search/Filter elements limit" -> "Search/Filter element limit" vitalijs.cemeris RESOLVED in r61637, r61639 sasha Discussed with martins-v: "Search/Filter elements limit" must be replaced with "Limit for selected elements" REOPENED vitalijs.cemeris RESOLVED in r61664, r61667 iivs as of later comments, it's clear that "Limit for selected elements" should be replaced with "Limit for search and filter results". RESOLVED in r62178 vitalijs.cemeris Updated .po files for "Limit for search and filter results" RESOLVED in r62184 iivs CLOSED |
Comment by richlv [ 2016 Aug 16 ] |
seeing how this actually got some interest, a similar issue for daemons created at |
Comment by richlv [ 2016 Aug 16 ] |
about (3) - "Limit for selected elements" might be misleading, as it impacts the amount of results that search or filter returns - or has that been changed ? if the idea is that search "selects" elements, that's not how most users think about it, even if the underlying database statement might have been "select" |
Comment by Martins Valkovskis [ 2016 Aug 16 ] |
The idea of (3) was to get rid of the "Search/Filter" in the beginning of the string, which did not look good at all and was misleading in the way that it was impossible to understand what was meant by "Search" (global search?). https://www.zabbix.com/documentation/3.2/manual/web_interface/frontend_sections/administration/general explains it in detail anyway. |
Comment by richlv [ 2016 Aug 16 ] |
how about "Limit for search and filter results" or similar ? |
Comment by Martins Valkovskis [ 2016 Aug 16 ] |
Sounds good to me, although longer. |
Comment by Aleksandrs Saveljevs [ 2016 Aug 17 ] |
(4) The setup welcome screen says "Welcome to Zabbix 3.0", but it should say "Welcome to Zabbix 3.2". asaveljevs RESOLVED in r61723 by making version detection automatic, based on ZABBIX_VERSION define. iivs I found that copyright notice had last year. Also fixed in this branch. See r62176 CLOSED |
Comment by Ivo Kurzemnieks [ 2016 Sep 01 ] |
TESTED, but close (3) before merging. |
Comment by vitalijs.cemeris (Inactive) [ 2016 Sep 02 ] |
Fixed in pre-3.2.0beta3 r62188 |
Comment by Martins Valkovskis [ 2016 Sep 12 ] |
"Event details" has a widget title - Acknowledges. Should be Acknowledgements REOPENING |
Comment by vitalijs.cemeris (Inactive) [ 2016 Sep 15 ] |
(5) Rename Acknowledges to Acknowledgements oleg.egorov CLOSED |
Comment by vitalijs.cemeris (Inactive) [ 2016 Sep 15 ] |
Fixed in:
|