[ZBX-11099] Active item update after maintenance can take long time Created: 2016 Aug 16  Updated: 2017 May 30  Resolved: 2016 Sep 21

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Server (S)
Affects Version/s: 2.2.13, 3.0.4, 3.2.0alpha1
Fix Version/s: 2.2.15rc1, 3.0.5rc1, 3.2.0beta1

Type: Incident report Priority: Major
Reporter: Andris Zeila Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

After maintenance without data collection ends nextcheck is recalculated for host items having type Zabbix agent (active). This update is done by iterating through all items (as there are not host->items[] index) and can lock the configuration cache for significant time.

This was done to avoid active items from showing up in queue after maintenance. But rather than recalculating nextcheck for active items we can apply host and item data_expected_from fields when calculating queue.



 Comments   
Comment by Andris Zeila [ 2016 Aug 16 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-11099

Comment by richlv [ 2016 Aug 16 ]

as this briefly confused me - probably "all host's active items" means all enabled items, not active agent items

wiper Only items of type Zabbix agent (active). Active item nextcheck is updated after receiving a new value, so during maintenance period there are no updates and server would put them into queue.

richlv oh, so that was actually just the active agent items... thanks for fixing me

Comment by Sandis Neilands (Inactive) [ 2016 Aug 19 ]

(1) [D] Queue documentation can be improved by listing types of items that are not shown in queue. From is_counted_in_item_queue() these are:

  • log, logrt, eventlog;
  • ITEM_TYPE_TRAPPER:
  • ITEM_TYPE_HTTPTEST:
  • ITEM_TYPE_SNMPTRAP:

wiper Added to queue documentation: https://www.zabbix.com/documentation/3.2/manual/config/items/queue#overview
RESOLVED

sandis.neilands Thanks! CLOSED.

Comment by Sandis Neilands (Inactive) [ 2016 Aug 23 ]

(2) [D] Items handled by proxies are included in the queue as well. This is surprising since proxies can be configured to hold off data (DataSenderFrequency) for an hour.

wiper Added to queue documentation: https://www.zabbix.com/documentation/3.2/manual/config/items/queue#overview
RESOLVED

sandis.neilands Thanks! CLOSED.

Comment by Sandis Neilands (Inactive) [ 2016 Aug 23 ]

Encountered some existing usability issues while working on this change.

ZBXNEXT-1504 [F] [S] - filtering in the queue details
ZBXNEXT-1502 [F] - paging in the queue details
ZBXNEXT-1708 [F] - improve zabbix server styling in queue by proxy
ZBXNEXT-633 [F] [S?]- Would be nice in the "Administration->Queue->Details" report show also key of the item and it's update interval
ZBXNEXT-2255 [S] [P] [F] - Queue should list only separate items by status

Comment by Sandis Neilands (Inactive) [ 2016 Aug 23 ]

Successfully tested.

Comment by Andris Zeila [ 2016 Aug 23 ]

Released in:

  • pre-2.2.15rc1 r61861
  • pre-3.0.5rc1 r61862
  • pre-3.2.0beta1 r61864
Comment by Alexander Vladishev [ 2016 Aug 23 ]

(3) compilation errors (3.0 and trunk)

dbconfig.c: In function ‘DCget_item_queue’:
dbconfig.c:8620:9: error: ‘host’ undeclared (first use in this function)
     if (host->data_expected_from > (data_expected_from = item->data_expected_from))
         ^
dbconfig.c:8620:9: note: each undeclared identifier is reported only once for each function it appears in
dbconfig.c:8620:58: error: ‘item’ undeclared (first use in this function)
     if (host->data_expected_from > (data_expected_from = item->data_expected_from))
                                                          ^
make[3]: *** [libzbxdbcache_a-dbconfig.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [install-recursive] Error 1
make[1]: *** [install-recursive] Error 1
make: *** [install-recursive] Error 1

wiper RESOLVED in 3.0 r61874 and trunk r61875

sandis.neilands CLOSED.

Generated at Sat Apr 20 04:39:25 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.