[ZBX-11304] Trigger wizard form can be easily broken Created: 2016 Oct 03  Updated: 2017 Jun 04  Resolved: 2017 Jun 04

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 3.0.5, 3.2.1, 3.4.0alpha1
Fix Version/s: 3.0.10rc1, 3.2.7rc1, 3.4.0alpha1

Type: Problem report Priority: Trivial
Reporter: Ivo Kurzemnieks Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: error, forms, js
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Sprint: Sprint 3, Sprint 4, Sprint 5, Sprint 6, Sprint 7, Sprint 8, Sprint 9
Story Points: 1

 Description   

It's possible to break trigger wizard form by following these steps:

  1. Type in an expression and click "And" or "Or" so that it is added in the keyword table.
  2. Try to save form and get a natural error. So far so good.
  3. Press "Add" so that the keyword is added to the expression table below.
  4. Type in another expression and press "And" or "Or".
  5. Press "Add" again to add it to the expression table.
  6. Experience the JS error:
    TypeError: key_tr is null

Bug was introduced in 2.4

 Comments   
Comment by Miks Kronkalns [ 2017 Mar 15 ]

(1) no translation string changes

iivs CLOSED

Comment by Miks Kronkalns [ 2017 Mar 15 ]

Fixed in svn://svn.zabbix.com/branches/dev/ZBX-11304

Comment by Natalja Romancaka [ 2017 Mar 23 ]

(2) [F]
Steps to reproduce:
1. Type in an expression and click "And" or "Or" so that it is added in the keyword table.
2. Try to save form and get an error.
3. Press "Remove" to remove expression from keyword table.
4. Type in another expression and press "And" or "Or".
5. Press "Add" to add it to the expression table.
Result: The same JS error

Miks.Kronkalns RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-11304 r66693

iivs CLOSED

Comment by Miks Kronkalns [ 2017 Mar 24 ]

(3) [F]
Another bug:
1) Type in an expression and click And/Or to move it to keywords table;
2) Try to save a form;
3) Now try to remove one or more keywords from table and save whole form again;
Result: removed keywords are back.

Miks.Kronkalns RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-11304 r66693

iivs CLOSED

Comment by Miks Kronkalns [ 2017 Mar 24 ]

(4) [F]
Another bug:
1) type in an expression (e.g. 'aaa') and click And/Or to move keyword to keywords table;
2) Now try to save whole form. After page reload keyword 'aaa' is still in table;
3) Press 'Add' to move keyword to expression table. Keyword 'aaa' disappears from keywords table;
4) Type in another expression (e.g. 'bbb') and press 'Add' button.
Result: New expression record combined from both keywords appears in expression table (regexp(aaa) and regexp(bbb)).

Miks.Kronkalns RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-11304 r66693

iivs CLOSED

Comment by Miks Kronkalns [ 2017 Mar 24 ]

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-11304

Comment by Miks Kronkalns [ 2017 May 26 ]

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-11304

Comment by Anna Kucenko (Inactive) [ 2017 May 31 ]

(6) [F]: wizard can’t save changes in expressions order created new trigger
Steps to reproduce:
1) Open up the trigger wizard form.
2) Type expression, press AND/OR, type Add to add it to list;
3) Type another expression, press Add to add it to list;
4) Type expression, press Add to add it to list;
5) Change expressions positions;
6) Press Add to save trigger;
7) Open up the trigger form and check positions;
Result: Expressions stay in order like it were added

Miks.Kronkalns Same problem can be observed also if page is reloaded, but instead of saved, error message is displayed.

Miks.Kronkalns RESOLVED in r68771.

iivs CLOSED

Comment by Miks Kronkalns [ 2017 Jun 01 ]

Fixed:

  • 3.0.10rc1 r68816
  • 3.2.7rc1 r68817
  • 3.4.0alpha1 (trunk) r68818
Generated at Thu Apr 18 18:21:28 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.