[ZBX-12554] item key helper different from the manual Created: 2017 Aug 22  Updated: 2024 Apr 10  Resolved: 2017 Sep 04

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 3.4.0beta2, 3.4.0
Fix Version/s: 3.4.2rc1, 4.0.0alpha1, 4.0 (plan)

Type: Patch request Priority: Trivial
Reporter: richlv Assignee: Gregory Chalenko
Resolution: Fixed Votes: 0
Labels: itemkeyhelper
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

actually trunk r71506 (3.4.0 not available in the version list)

Attachments: File ZBX-12554.patch    
Team: Team B
Team: Team B
Sprint: Sprint 15, Sprint 16
Story Points: 0.25

 Description   

there are two minor problems with the item key helper content, which are correct in the manual.

  • manual has the grammatically correct "Various information about specific process(es)", while frontend item key helper has "Different information about specific process(es)"
  • in the item key helper, "vfs.dir.size" is listed after "vfs.f*" items - incorrect sorting

 Comments   
Comment by richlv [ 2017 Aug 22 ]

the attached patch fixes both issues

"various / different" might be worth fixing in earlier versions, too

oleg.egorov Thank you, richlv!

Comment by Rostislav Palivoda [ 2017 Aug 22 ]

(1) [D] Do you agree to renaming - martins-v?

martins-v Yes, should be fixed.

Comment by Gregory Chalenko [ 2017 Aug 23 ]

(2) [F] Translation strings changes:

Strings added:

  • Various information about specific process(es). Returns float

Strings deleted:

  • Different information about specific process(es). Returns float

oleg.egorov CLOSED

Comment by Gregory Chalenko [ 2017 Sep 01 ]

Fixed in:

  • 3.4.2rc1 r72073
  • 4.0.0aplha1 (trunk) r72074
Comment by richlv [ 2017 Sep 18 ]

looks like the attached patch was not used, and vfs.dir.size was not added to the active item array. this is reported as ZBX-12738 .

additionally, it looks like code review was not performed - that would have likely caught this early.

Generated at Sat Apr 20 15:03:29 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.