[ZBX-12603] Rework dashboard sharing and properties windows Created: 2017 Aug 25  Updated: 2018 May 17  Resolved: 2018 May 14

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 3.4.1rc1, 3.4 (plan), 4.0.0alpha1
Fix Version/s: 4.0.0alpha7, 4.0 (plan)

Type: Problem report Priority: Trivial
Reporter: Miks Kronkalns Assignee: Miks Kronkalns
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Success_font.png    
Issue Links:
Duplicate
is duplicated by ZBX-12591 Dashboard properties should be submit... Closed
Sub-task
depends on ZBXNEXT-4132 Dashboard name validation in properti... Open
depends on ZBXNEXT-4149 Keyboard popup interaction (Z4beta1) Closed
depends on ZBX-12809 Blured overlay dialogues Closed
part of ZBX-12814 Success message on successful dashboa... Closed
Epic Link: DEV-654
Team: Team D
Sprint: Sprint 15, Sprint 16, Sprint 17, Sprint 18, Sprint 19, Sprint 20, Sprint 21, Sprint 22, Sprint 23, Sprint 24, Sprint 25, Sprint 26, Sprint 27, Sprint 28, Sprint 29, Sprint 30, Sprint 31, Sprint 32, Sprint 33, Sprint 34
Story Points: 1.5

 Description   

This task originates from ZBXNEXT-2102 sub-task 68.

Modal windows should be re-worked to load them through the ajax requests, instead of using a hidden HTML form.

Overlay dialogue form is not submitted on enter for:

  • Dashboard properties
  • Dashboard sharing (if there will be any fields, where enter should work like this)


 Comments   
Comment by Miks Kronkalns [ 2017 Aug 25 ]

Fixed in development branch:

  • 3.4 in ^/branches/dev/ZBXNEXT-2102_68 r71672, r71674
  • 4.0 in svn://svn.zabbix.com/branches/dev/ZBX-12603-4.0
Comment by Valdis Murzins [ 2017 Oct 03 ]

(3) [F] In sharing dialogue there should be error messages in following cases:

  • User opened dashboard with READ/WRITE permissions, WRITE permissions were removed, user tries to open sharing form.
  • User opened dashboard and sharing form with READ/WRITE permissions, WRITE permissions were removed, user tries to update in sharing form.

Both error messages should be displayed in sharing form.

Miks.Kronkalns Same issue also in dashboard properties window. Update is left as is since by applying changes, nothing has been changed in server side.

RESOLVED in r73174

vmurzins CLOSED

Comment by Miks Kronkalns [ 2017 Oct 04 ]

(9) In files monitoring.dashboard.sharing_form.php, class.cnavtree.js and dashboard.grid.js double quotes used for string wrapping instead of single quotes.

Miks.Kronkalns RESOLVED in r73155.

vmurzins CLOSED

Comment by Valdis Murzins [ 2018 May 14 ]

Fixed in: 4.0.0alpha7 (trunk) r80786

Generated at Thu Mar 28 12:06:07 EET 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.