[ZBX-13586] With trigger correlation recovery events are created even if no problems are recovered Created: 2018 Mar 06  Updated: 2024 Apr 10  Resolved: 2018 Mar 13

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Server (S)
Affects Version/s: 3.4.7
Fix Version/s: 3.4.8rc1, 4.0.0alpha5, 4.0 (plan)

Type: Problem report Priority: Trivial
Reporter: Andris Zeila Assignee: Viktors Tjarve
Resolution: Fixed Votes: 0
Labels: eventcorrelation
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Causes
caused by ZBX-12800 Problem with depended trigger after r... Closed
Team: Team A
Sprint: Sprint 29
Story Points: 1

 Description   
Index: src/zabbix_server/events.c
===================================================================
--- src/zabbix_server/events.c	(revision 78371)
+++ src/zabbix_server/events.c	(working copy)
@@ -2194,12 +2194,13 @@
 		}
 		else
 		{
-			/* With trigger correlation enabled the recovery event recovers   */
-			/* all problem events generated by the same trigger and matching  */
-			/* recovery event tags. Te trigger value is set to OK only if all */
-			/* problem events were recovered.                                 */
+			/* With trigger correlation enabled the recovery event recovers    */
+			/* all problem events generated by the same trigger and matching   */
+			/* recovery event tags. The trigger value is set to OK only if all */
+			/* problem events were recovered.                                  */
 
 			value = TRIGGER_VALUE_OK;
+			event->flags = ZBX_FLAGS_DB_EVENT_UNSET;
 
 			for (j = 0; j < problems.values_num; j++)
 			{
@@ -2211,6 +2212,7 @@
 					{
 						recover_event(problem->eventid, EVENT_SOURCE_TRIGGERS,
 								EVENT_OBJECT_TRIGGER, event->objectid);
+						event->flags = ZBX_FLAGS_DB_EVENT_CREATE;
 					}
 					else
 						value = TRIGGER_VALUE_PROBLEM;


 Comments   
Comment by Andris Zeila [ 2018 Mar 06 ]

Regression from ZBX-12800

Comment by Viktors Tjarve [ 2018 Mar 08 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-13586

Comment by Andris Zeila [ 2018 Mar 09 ]

Successfully tested

Comment by Viktors Tjarve [ 2018 Mar 09 ]

Released in:

  • 3.4.8rc1 r78509
  • 4.0.0alpha5 r78510
Generated at Fri Apr 26 07:42:39 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.