1.7.2

DEV branch: ZBX-1362

Raw SQL queries changed to ZABBIX API method. Now it requires about 300 queries to get a report by day (was ~2000) and 50 to get report by week.

this seems to have increased memory usage notably, though. trunk renders that page with 64mb memory limit just fine, dev branch runs out of memory...

ping. what about the memory usage increase ? should it be that big ?

Memory usage is lowered. Fix tested

May merge.

today's updates brought memory usage down from some 68 megs to 35 - while still quite high, it's half of what it was, so good to merge

merged: branches/1.8 rev 15144

The fix was absolutely incorrect. Now we have hardcoded media types, it wasn't so before.

I didn't really find hardcoded media types there. This line looks like one:

$summary[$userid]['medias'] = array('1'=>0, '2'=>0, '3'=>0, '4'=>0);

but numbers 1, 2, 3 and 4 do not refer to media types, they refer to position of a number in string '17 (17/0/0/0)' in report4.php

The media type them selves are referred here:

$summary[$ai['userid']]['medias'][$ai['mediatypeid']]++;

hmm. in 1.8 branch, i have 3 media types defined. footer says :

all (Email/Jabber/SMS)

cell contents say :

0 (0/0/0/0)

if i add two more media types to have 5 of them, table cell contents don't change

Thank you, richlv, now I get it.

fix commited to 1.8 branch rev 18057 and trunk rev 18058

If no media types are defined, empty parentheses will be shown, like this: "0 ()". Is this intended?

maybe then the table should not be constructed at all and just a message "No media types defined" displayed ?

In this case you might want to create another issue for that, since this one is already merged.

The "0 ()" issue moved to ZBX-3566.

this one works ok - after code review could be closed

Hm, why do I see single-media-type.png when viewing a weekly report for a single media type?

Aleksandrs Saveljevs, I will fix this in ZBX-3566.