[ZBX-14363] The Zabbix Proxy Debian deb package's zabbix_proxy.conf file doesn't use a default Include= Created: 2018 May 15 Updated: 2018 Sep 21 Resolved: 2018 Sep 21 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Installation (I), Packages (C), Proxy (P) |
Affects Version/s: | 3.4.9, 4.0.0alpha6 |
Fix Version/s: | None |
Type: | Incident report | Priority: | Major |
Reporter: | Marco Hofmann | Assignee: | Unassigned |
Resolution: | Duplicate | Votes: | 0 |
Labels: | None | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified | ||
Environment: |
All Debian Operating Systems which use the offical repo.zabbix.com |
Issue Links: |
|
Description |
I'm a huge fan of "the Debian way" (https://wiki.debian.org/DontBreakDebian) Part of that is imho that you should have the option to not modify the default config files of any package, and rely instead on a default include. This has the precious advantage that you may let the original package maintainer keep the config file as he desires and keep meaningful changes for the future; in example new default values for a major release 3.4->4.0 To make practical examples: There are three common Debian packages which do exactly this: MySQL or MariaDB, Dovecot (the popular IMAP Server) and the Zabbix Agent from repo.zabbix.com ! MariaDB:
/etc/mysql/mariadb.cnf # Import all .cnf files from configuration directory !includedir /etc/mysql/mariadb.conf.d/ Dovecot:
/etc/dovecot/dovecot.conf # Most of the actual configuration gets included below. The filenames are # first sorted by their ASCII value and parsed in that order. The 00-prefixes # in filenames are intended to make it easier to understand the ordering. !include conf.d/*.conf Zabbix Agent:
/etc/zabbix/zabbix_agentd.conf ### Option: Include # You may include individual files or all files in a directory in the configuration file. # Installing Zabbix will create include directory in /usr/local/etc, unless modified during the compile time. # # Mandatory: no # Default: # Include= Include=/etc/zabbix/zabbix_agentd.d/*.conf # Include=/usr/local/etc/zabbix_agentd.userparams.conf # Include=/usr/local/etc/zabbix_agentd.conf.d/ # Include=/usr/local/etc/zabbix_agentd.conf.d/*.conf And to compare those three examples with the zabbix_proxy.conf from Zabbix 4.0 alpha6:
/etc/zabbix/zabbix_proxy.conf ### Option: Include # You may include individual files or all files in a directory in the configuration file. # Installing Zabbix will create include directory in /usr/local/etc, unless modified during the compile time. # # Mandatory: no # Default: # Include= # Include=/usr/local/etc/zabbix_proxy.general.conf # Include=/usr/local/etc/zabbix_proxy.conf.d/ # Include=/usr/local/etc/zabbix_proxy.conf.d/*.conf
As you see, there is no way to write your own Zabbix Proxy conf files, without editing the original file. This annoys me, cause Debian will ask me if I want to keep my modified zabbix_proxy.conf or overwrite it with the maintainer's version everytime there are significant changes. So please add a default include like: Include=/etc/zabbix/zabbix_proxy.d/*.conf to your repo.zabbix.com deb files tl;dr |
Comments |
Comment by Aigars Kadikis [ 2018 Sep 21 ] |
Hello Marko! This feature is not related only on Debian but quite on all systems. I must ask you to repost the idea inside a new feature request or vote/attach a comment on ZBXNEXT-4641 which has some similarities with your idea. I will close this issue for now. Regards, |