|
Causes |
|||
| causes |
|
Running make requires aclocal | Closed |
Team A
[ZBX-14941] Source tarball missing tests/ Created: 2018 Oct 03 Updated: 2024 Apr 10 Resolved: 2018 Nov 12 |
|
| Status: | Closed |
| Project: | ZABBIX BUGS AND ISSUES |
| Component/s: | Installation (I) |
| Affects Version/s: | 4.0.0 |
| Fix Version/s: | 4.0.2rc1, 4.2.0alpha1, 4.2 (plan) |
| Type: | Problem report | Priority: | Major |
| Reporter: | Dmitry Smirnov | Assignee: | Michael Veksler |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | unittests | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Team: | Team A |
||||||||
| Sprint: | Sprint 44, Sprint 45, Sprint 46, Nov 2018 | ||||||||
| Story Points: | 1 | ||||||||
| Description |
|
Building 4.0.0 from source fails in autoreconf/automake as follows: configure.ac:1718: error: required file 'tests/Makefile.in' not found configure.ac:1718: error: required file 'tests/libs/Makefile.in' not found configure.ac:1718: error: required file 'tests/libs/zbxcommon/Makefile.in' not found configure.ac:1718: error: required file 'tests/libs/zbxconf/Makefile.in' not found configure.ac:1718: error: required file 'tests/libs/zbxdbcache/Makefile.in' not found configure.ac:1718: error: required file 'tests/libs/zbxdbhigh/Makefile.in' not found configure.ac:1718: error: required file 'tests/libs/zbxhistory/Makefile.in' not found configure.ac:1718: error: required file 'tests/libs/zbxjson/Makefile.in' not found configure.ac:1718: error: required file 'tests/libs/zbxsysinfo/Makefile.in' not found configure.ac:1718: error: required file 'tests/libs/zbxsysinfo/linux/Makefile.in' not found configure.ac:1718: error: required file 'tests/libs/zbxsysinfo/common/Makefile.in' not found configure.ac:1718: error: required file 'tests/libs/zbxcommshigh/Makefile.in' not found configure.ac:1718: error: required file 'tests/libs/zbxalgo/Makefile.in' not found autoreconf: automake failed with exit status: 1 And of course "tests" are missing from source tarball... Please include tests into source distribution. Thanks. |
| Comments |
| Comment by Glebs Ivanovskis [ 2018 Oct 03 ] |
|
Have you added tests directory yourself? Or perhaps you are running configure from some other place where you have tests directory? I've just downloaded source tarball and compiled an agent with no issues. Make sure you run configure script from a place where there are no occasional tests directory. If you are really curious about tests, you can always checkout from SVN. |
| Comment by Dmitry Smirnov [ 2018 Oct 03 ] |
|
Tests are missing from source tarball - this is, clearly, a problem. No I did not re-add tests from SVN - this should be done for tarball release - that's precisely what this bug is about. Your build probably succeeded (which is beyond the point) because you did not run autoreconf to re-build `configure` script. I know how to run configure and I hope we are not dealing with denial... |
| Comment by Glebs Ivanovskis [ 2018 Oct 03 ] |
...or a policy.
You're right, I haven't run autoreconf. By the way, why would you do that? |
| Comment by Dmitry Smirnov [ 2018 Oct 03 ] |
|
Best practice. Running `autoreconf` to ensure build integrity is a standard (default) practice in Debian. |
| Comment by Glebs Ivanovskis [ 2018 Oct 03 ] |
|
Good to know. Thank you for the explanation! |
| Comment by Michael Veksler [ 2018 Nov 09 ] |
|
Available in:
|
| Comment by dimir [ 2018 Nov 26 ] |
|
This one caused a regression: https://support.zabbix.com/browse/ZBX-15211 |
