Team A
[ZBX-15022] Parameters of removed item preprocessing steps are not removed from cache Created: 2018 Oct 17 Updated: 2024 Apr 10 Resolved: 2018 Nov 05 |
|
| Status: | Closed |
| Project: | ZABBIX BUGS AND ISSUES |
| Component/s: | Server (S) |
| Affects Version/s: | 3.4.14, 4.0.1rc1, 4.2.0alpha1 |
| Fix Version/s: | 3.4.15rc1, 4.0.2rc1, 4.2.0alpha1, 4.2 (plan) |
| Type: | Problem report | Priority: | Major |
| Reporter: | Andris Zeila | Assignee: | Andris Zeila |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | cache, memoryleak | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Team: | Team A |
| Team: | Team A |
| Sprint: | Sprint 45, Sprint 46, Nov 2018 |
| Story Points: | 0.5 |
| Description |
|
Preprocessing step parameters are stored in string pool and not released when preprocessing step is removed from cache.
Index: src/libs/zbxdbcache/dbconfig.c
===================================================================
--- src/libs/zbxdbcache/dbconfig.c (revision 85639)
+++ src/libs/zbxdbcache/dbconfig.c (working copy)
@@ -4363,6 +4363,7 @@
}
}
+ zbx_strpool_release(op->params);
zbx_hashset_remove_direct(&config->preprocops, op);
}
|
| Comments |
| Comment by Andris Zeila [ 2018 Nov 05 ] |
|
Released in:
As the leak is in shared string pool it's not critical. It could be problematic only if items with unique preprocessing step parameters or triggers with unique recovery expressions are being created and removed. In such case those unique strings would accumulate in string pool, eventually exhausting free space. |