[ZBX-15379] Lots of -Wimplicit-fallthrough warnings when compiling with GCC 7 and -Wextra Created: 2018 Dec 27  Updated: 2024 Apr 10  Resolved: 2019 Feb 10

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Agent (G), Proxy (P), Server (S)
Affects Version/s: 4.2.0alpha3
Fix Version/s: 4.0.5rc1, 4.2.0beta1, 4.2 (plan)

Type: Problem report Priority: Trivial
Reporter: Glebs Ivanovskis Assignee: Andrejs Kozlovs
Resolution: Fixed Votes: 1
Labels: codequality
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: DEV-680
Team: Team A
Sprint: Sprint 48, Jan 2019, Sprint 49 (Feb 2019)
Story Points: 0.125

 Description   

See https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough for the ways to silence this type of warning.



 Comments   
Comment by Glebs Ivanovskis [ 2018 Dec 27 ]
$ gcc --version
gcc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Comment by Andris Mednis [ 2019 Jan 25 ]

(2) Thanks to asaveljevs for finding a small mistake in 4.0 conf/zabbix_server.conf:

### Option: StartTimers
#       Number of pre-forked instances of timers.
#       Timers process maintenance periods.
#       Only the first timer process handles host maintenance updates. Problem suppression updates are shared.
#       between all timers.

Delete the dot after 'shared'.
RESOLVED in rev. 89459 in svn://svn.zabbix.com/branches/dev/ZBX-15379

vso CLOSED

Comment by Andrejs Kozlovs [ 2019 Feb 05 ]

Fixed in:

  • pre-4.0.5rc1 r89465
  • pre-4.2.0alpha4 (trunk) r89466
Generated at Fri Apr 26 01:18:30 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.