[ZBX-15444] Strange values are accepted as valid Numeric (float) values Created: 2019 Jan 12  Updated: 2024 Apr 10  Resolved: 2019 Apr 12

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Proxy (P), Server (S)
Affects Version/s: 2.2.24rc1, 3.0.25rc1, 4.0.4rc1, 4.2.0alpha3
Fix Version/s: 4.0.7rc1, 4.2.1rc1, 4.4.0alpha1, 4.4 (plan)

Type: Problem report Priority: Minor
Reporter: Glebs Ivanovskis Assignee: Andrejs Sitals (Inactive)
Resolution: Fixed Votes: 0
Labels: float, trapper, validation
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File float.png    
Issue Links:
Sub-task
part of ZBX-15643 del_zeros() may convert invalid numbe... Closed
Team: Team C
Sprint: Sprint 48, Jan 2019, Sprint 49 (Feb 2019), Sprint 50 (Mar 2019), Sprint 51 (Apr 2019)
Story Points: 1

 Description   

See ZBX-10784 for initial report.

Steps to reproduce:

  1. Create host "Testing"
  2. Create item:
    • Name: "Trapper"
    • Type: Zabbix Trapper
    • Key: float.trapper
    • Type of information: Numeric (float)
  3. Execute 
    $ src/zabbix_sender/zabbix_sender -z localhost -s Testing -k float.trapper -o ' "+ "+ + + -3.0  "   " '

Result:
Value is accepted:

info from server: "processed: 1; failed: 0; total: 1; seconds spent: 0.001196"
sent: 1; skipped: 0; total: 1

Expected:
"+ "+ + + -3.0 " " is by no means a valid decimal number and item should become not supported.

 Comments   
Comment by Vladislavs Sokurenko [ 2019 Jan 28 ]

Maybe something like:

Input value Expected Actual Should be
'3.0' valid valid valid
'+3.0' valid valid valid
'-3.0' valid valid valid
'+ 3.0' valid as space before number is removed valid invalid
' +3.0' valid as space before sign is removed valid valid
' +3.0 ' valid as space after number is removed valid valid
'- 3.0' should it be valid invalid invalid
'+-3.0' previously this was valid and should continue to be valid ? (must be invalid ) valid invalid
'-+3.0' previously this was invalid, should it be valid (-3.0) ? (must remain invalid ) invalid invalid
'++3.0' previously was valid but should be invalid (must become invalid ) valid invalid
'--3.0' previously was invalid but should be valid (3.0) ? (continue being invalid ) invalid invalid
'3. 0' previously was invalid and should continue being invalid invalid invalid
'"3.0"' valid, quotes on both sides valid valid
' "3.0" ' valid valid valid
'" 3.0"' valid valid invalid
'"3.0 "' valid valid invalid
' "3.0 "' valid, spaces are allowed before first quote ? valid invalid
' "3.0 " ' valid, spaces are allowed after last quote ? valid invalid
'+"3.0"' invalid, can only start and end with quote (must become invalid ) valid invalid
'-"3.0"' invalid, can only start and end with quote (must become invalid ) invalid invalid
'"3.0' invalid, quotes only on one side (must become invalid ) valid invalid
'3.0"' invalid, quotes only on one side (must become invalid ) valid invalid
'""3.0"' invalid, can only start and end with one quote (result "3.0) (must become invalid ) valid invalid
'"3.0""' invalid, too many quote characters on right side (result 3.0") (must become invalid ) valid invalid
'"3.0"+' invalid, only white space is allowed after last quote (result 3.0") invalid invalid
'"3.0"-' invalid, only white space is allowed after last quote (result 3.0") invalid invalid
Comment by Andrejs Sitals (Inactive) [ 2019 Feb 21 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-15444

Comment by Andrejs Sitals (Inactive) [ 2019 Apr 11 ]

Available in versions:

  • pre-4.0.7rc1 r92467
  • pre-4.2.1rc1 r92474
  • pre-4.4.0alpha1 r92476
Comment by Glebs Ivanovskis [ 2019 Apr 11 ]

Dear asitals, you could have used single quoted YAML strings to avoid escaping so many double quotes in test cases.

Generated at Tue Apr 23 10:52:14 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.