[ZBX-15714] Obsolete constants in common.h Created: 2019 Feb 25  Updated: 2019 Feb 26  Resolved: 2019 Feb 26

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Proxy (P), Server (S)
Affects Version/s: 4.2.0beta2
Fix Version/s: 4.0.6rc1, 4.2.0beta2, 4.2 (plan)

Type: Problem report Priority: Trivial
Reporter: Glebs Ivanovskis Assignee: Alexander Vladishev
Resolution: Fixed Votes: 0
Labels: codequality, preprocessing
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Team: Team B
Sprint: Sprint 49 (Feb 2019)
Story Points: 0

 Description   

The following constants from include/common.h are only used in src/libs/zbxdbupgrade/dbupgrade_3030.c (as a part of ZBXNEXT-1443):

/* item multiplier types */
#define ITEM_MULTIPLIER_DO_NOT_USE		0
#define ITEM_MULTIPLIER_USE			1

/* item delta types */
#define ITEM_STORE_AS_IS			0
#define ITEM_STORE_SPEED_PER_SECOND		1
#define ITEM_STORE_SIMPLE_CHANGE		2

These definitions should be moved to the respective source file using them or removed completely and replaced in upgrade patch with actual values.



 Comments   
Comment by Alexander Vladishev [ 2019 Feb 26 ]

Fixed in 4.0.6rc1 and 4.2.0beta2 r90241.

Generated at Fri Mar 29 01:03:40 EET 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.