[ZBX-16029] zbxjson.h includes stdarg.h for no reason Created: 2019 Apr 21  Updated: 2024 Apr 10  Resolved: 2019 May 17

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Agent (G), Proxy (P), Server (S)
Affects Version/s: 4.4.0alpha1
Fix Version/s: 4.0.8rc1, 4.2.2rc1, 4.4.0alpha1, 4.4 (plan)

Type: Problem report Priority: Trivial
Reporter: Glebs Ivanovskis Assignee: Andrejs Kozlovs
Resolution: Fixed Votes: 0
Labels: codequality, headers
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Team: Team A
Sprint: Sprint 51 (Apr 2019), Sprint 52 (May 2019)
Story Points: 0.125

 Description   

Suggested patch:

Index: include/zbxjson.h
===================================================================
--- include/zbxjson.h	(revision 92868)
+++ include/zbxjson.h	(working copy)
@@ -20,8 +20,6 @@
 #ifndef ZABBIX_ZJSON_H
 #define ZABBIX_ZJSON_H
 
-#include <stdarg.h>
-
 #define ZBX_PROTO_TAG_CLOCK			"clock"
 #define ZBX_PROTO_TAG_NS			"ns"
 #define ZBX_PROTO_TAG_DATA			"data"


 Comments   
Comment by Glebs Ivanovskis [ 2019 Apr 21 ]

Same story:

Index: include/zbxmedia.h
===================================================================
--- include/zbxmedia.h	(revision 92868)
+++ include/zbxmedia.h	(working copy)
@@ -21,7 +21,6 @@
 #define ZABBIX_ZBXMEDIA_H
 
 #include "sysinc.h" /* using "config.h" would be better, but it causes warnings when compiled with Net-SNMP */
-#include "zbxalgo.h"
 
 #define ZBX_MEDIA_CONTENT_TYPE_TEXT	0
 #define ZBX_MEDIA_CONTENT_TYPE_HTML	1
Index: src/libs/zbxmedia/email.c
===================================================================
--- src/libs/zbxmedia/email.c	(revision 92868)
+++ src/libs/zbxmedia/email.c	(working copy)
@@ -21,6 +21,7 @@
 #include "log.h"
 #include "comms.h"
 #include "base64.h"
+#include "zbxalgo.h"
 
 #include "zbxmedia.h"
Comment by Glebs Ivanovskis [ 2019 Apr 21 ]

And

Index: include/discovery.h
===================================================================
--- include/discovery.h	(revision 92868)
+++ include/discovery.h	(working copy)
@@ -21,7 +21,6 @@
 #ifndef ZABBIX_DISCOVERY_H
 #define ZABBIX_DISCOVERY_H
 
-#include "zbxjson.h"
 #include "comms.h"
 
 typedef struct
Comment by Andrejs Kozlovs [ 2019 May 07 ]

Fixed in:

  • 4.0.8rc1 a6eeb2fce7c
  • 4.2.2rc1 ad22d3ba5cb
  • 4.4.0alpha1 (trunk) a3b032b1cbd
Generated at Thu Apr 25 23:53:49 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.