[ZBX-16166] Zabbix fping feature detection does not work with fping 4.2 (or builds since 10 Feb 2017) Created: 2019 May 23  Updated: 2024 Apr 10  Resolved: 2019 Jun 07

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Proxy (P), Server (S)
Affects Version/s: 4.2.1
Fix Version/s: 4.0.10rc1, 4.2.4rc1, 4.4.0alpha1, 4.4 (plan)

Type: Problem report Priority: Major
Reporter: Ian Gregory Assignee: Andrejs Kozlovs
Resolution: Fixed Votes: 2
Labels: fping, icmpping, ping
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Team: Team A
Team: Team A
Sprint: Sprint 52 (May 2019), Sprint 53 (Jun 2019)
Story Points: 1

 Description   

 

A commit was made to the fping repository which has changed the help output from the fping command, specifically, the way that the options for source IP are displayed. Previously, the short options would be followed by a space; now they're followed by a comma.

The Zabbix fping feature detection code in the function `get_source_ip_option` of `icmpping.c` searches the fping help output for the short option followed by a space, and thus no longer detects the source IP option (as it's now followed by a comma)

This causes some ICMP checks to fail on systems with multiple interfaces.



 Comments   
Comment by Ian Gregory [ 2019 May 23 ]

This seems to be an issue with fping versions from v4.0 onwards

Comment by Andrejs Kozlovs [ 2019 Jun 04 ]

Fixed in:

  • 4.0.9rc1 6900ed0163c
  • 4.2.3rc1 2fb68319d5f
  • 4.4.0alpha1 (trunk) b6f7b638b3c
Generated at Thu Apr 18 23:10:50 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.