[ZBX-16368] fping double call Created: 2019 Jul 12  Updated: 2024 Apr 10  Resolved: 2019 Oct 15

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Proxy (P), Server (S)
Affects Version/s: 4.0.10, 4.2.4
Fix Version/s: 4.0.14rc1, 4.2.8rc1, 4.4.1rc1, 5.0.0alpha1, 5.0 (plan)

Type: Problem report Priority: Trivial
Reporter: Michael Veksler Assignee: Andrejs Kozlovs
Resolution: Fixed Votes: 0
Labels: fping
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Sub-task
part of ZBX-7798 after upgrade to 2.2.2 zabbix queue g... Closed
Team: Team A
Sprint: Sprint 56 (Sep 2019), Sprint 55 (Aug 2019), Sprint 54 (Jul 2019), Sprint 57 (Oct 2019)
Story Points: 0.5

 Description   

Steps to reproduce:
Begin from fping version 4.0 - binaries fping and fping6 are the same and logic based on fping v3.x behavior is not optimal in case of ipv6 and without configured source ip. The logic makes double call to fping.

if (0 != (fping_existence & FPING_EXISTS))
	offset += zbx_snprintf(tmp + offset, sizeof(tmp) - offset,
			"%s %s 2>&1 <%s;", CONFIG_FPING_LOCATION, params, filename);

if (0 != (fping_existence & FPING6_EXISTS))
	zbx_snprintf(tmp + offset, sizeof(tmp) - offset,
			"%s %s 2>&1 <%s;", CONFIG_FPING6_LOCATION, params6, filename);

Result:
The do_ping() performance for ipv6 case in 2 times worse

Expected:
Detect fping ipv6 support and do not make the second call

 Comments   
Comment by Andrejs Kozlovs [ 2019 Oct 14 ]

Fixed in:

Generated at Tue Apr 23 20:31:49 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.