[ZBX-1946] row and column span in screens exceeds normal cell area Created: 2010 Feb 05  Updated: 2017 May 30  Resolved: 2012 Dec 10

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.1, 1.9.0 (alpha)
Fix Version/s: 2.0.4rc1, 2.0.5rc1, 2.1.0

Type: Incident report Priority: Major
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: screens, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

trunk rev 9927.


Attachments: PNG File spanning.png    
Issue Links:
Duplicate
duplicates ZBXNEXT-904 Redesign Configuration->Screens Closed

 Description   

screate a 1x1 screen, insert into it any element and set row & column span for it to be 2 & 2. as a result, this element bleeds over to the control column and row - see the screenshot



 Comments   
Comment by Eduards Samersovs (Inactive) [ 2012 Feb 28 ]

User must understand what he doing, increasing colspan or rowspan is needed only then it's needed, otherwise table probably will be fail..

Comment by richlv [ 2012 Mar 03 ]

with such reasoning we could remove any sanity checks or validation. disagree, proper span validation is important

Comment by Pavels Jelisejevs (Inactive) [ 2012 Sep 10 ]

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-1946.

Comment by Alexey Fukalov [ 2012 Sep 10 ]

(1)
Seems row span sometimes validated as row span, i set row span 2 and get error about column span.

<pavels> RESOLVED.

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Sep 10 ]

(2)
As we discussed make checkSpan and checkSpanInBounds methods check both spans at once.

<pavels> RESOLVED.

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Sep 10 ]

(3)
In validate* methods API calls probably should be changed to something more lightweight either direct raw sql or select constructor.

<pavels> RESOLVED.

<Vedmak> CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Oct 04 ]

Fixed in 2.0.4rc1 r30600 and 2.1.0 r30601.

CLOSED.

Comment by richlv [ 2012 Oct 08 ]

(4) this added error messages like :
Incorrect row span provided for screen element.
Incorrect column span provided for screen element.

that's great... but maybe we can somehow indicate which element is that ?
maybe x & y or some other way

jelisejev Hm, how about "Incorrect row span provided for screen element located at X - 3 and Y - 4."? Doesn't sound good to me, but I can't think of a better alternative.

jelisejev RESOLVED.

jelisejev CLOSED.

Comment by richlv [ 2012 Oct 08 ]

(5) "Screen elements column span is too big."

does that refer to a single element's span, or is it 'undefined' (can be any amount of elements) ? in the first case we probably should add apostrophe, in the second case - use singular "element".

also, similar as (4), can/do we provide more information here ?

jelisejev RESOLVED.

jelisejev CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Dec 10 ]

Improved error messages in svn://svn.zabbix.com/branches/dev/ZBX-1946. RESOLVED.

Comment by Alexey Fukalov [ 2012 Dec 12 ]

(1)
New messages have two "%1$s" references.

When it's fixed, can be merged.

jelisejev CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Dec 12 ]

Error messages improved in 2.0.5rc1 r32086 and 2.1.0 r32088.

CLOSED.

Generated at Thu Mar 28 15:22:05 EET 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.