[ZBX-20162] Maintenance Period interrupted by Daylight Saving CEST to CET Created: 2021 Nov 02 Updated: 2022 Feb 12 Resolved: 2022 Feb 12 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Server (S) |
Affects Version/s: | None |
Fix Version/s: | None |
Type: | Problem report | Priority: | Trivial |
Reporter: | H.L. | Assignee: | Antons Sincovs |
Resolution: | Won't fix | Votes: | 0 |
Labels: | maintenance, period, server | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified | ||
Environment: |
zabbix-agent.x86_64 5.0.6-1.el7 @zabbix |
Attachments: |
![]() ![]() ![]() ![]() |
||||||||
Issue Links: |
|
Description |
It seems the maintenance period is interrupted by daylight saving from CEST to CET. Hosts which where in maintenance mode without data collection, where monitored and triggered in a timeframe between 31.10.2021 23:00 and 31.10.2021 23:59. Because of this we got a lot of false alarms, which trigger our emergency response team. Since we had daylight saving on 31.10.2021 at 03:00 this day had 25 hours. I guess this is the reason our maintenance period was interrupted for 1 hour. Steps to reproduce:
Result: This host in maintenance host group will be monitored again. It is out of maintenance mode. The trigger action of this host will be fired. Expected: |
Comments |
Comment by Antons Sincovs [ 2022 Jan 31 ] |
Hello, H.L. Thank you for the observation. Though it seems like a bug - actually it is not. As Zabbix internal logic evaluates 1 day as 24 hours. So when turning clocks back by 1 hour on the DST day in Autumn the day actually has 25 hours instead of the usual 24. But Zabbix still calculates 1 day period as 24 hours and this leads to a maintenance period starting at 0 hour ending at the 23rd (24 -1) hour of such a special (DST) day. On the DST day in Spring - this very logic would lead to the situation where 24 hour maintenance period ends at the 1st hour of the next day as the DST day would have 23 hours. |
Comment by H.L. [ 2022 Jan 31 ] |
Hello Antons Sincovs Thanks for your feedback. As you see in the problem description I already suspected that Zabbix calculates with a fixed 24 hours period per day. Per definition a daylight saving day has 23 to 25 hours. Thus, this is nothing a user should need to care of while creating maintenance windows. This is a bug and the zabbix code should take care of these situations. On such days it should calculate with 23 or 25 hours, not 24 hours. Think of a calendar app which displays every month as 31 days long. Of course, the user could care of that, but it is neither convenient nor intuitive and decreases the user experience. Further this bug creates false positives and produces needless workload for users. Regards, Holger |
Comment by Antons Sincovs [ 2022 Feb 02 ] |
Dear Holger! I agree with you that it is not intuitive. But "day" here is not like a day in a calendaring app, but it is a period of time under which precisely 24 hours are aggregated. These periods are hardcoded. For example, we have 1 month period defined as 30 days and 1 year as 365 days. I have had a talk with developers and they will consider what can be done about it in regards to maintenance periods. Also created a ZBXNEXT-7463 with the request for processing such cases. Regards, Antons |