[ZBX-2376] tcp and tcp_perf checks work without port specified Created: 2010 Apr 26  Updated: 2017 May 30  Resolved: 2010 Jun 04

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Server (S)
Affects Version/s: None
Fix Version/s: 1.8.3, 1.9.0 (alpha)

Type: Incident report Priority: Minor
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by ZBX-808 ntp service syntax not consistent Closed

 Description   

simple checks tcp and tcp_perf return some data even if no port is specified.
instead, they should turn unsupported to indicate incorrect configuration

 Comments   
Comment by Aleksandrs Saveljevs [ 2010 May 28 ]

Changes:

(1) Removed support for obsolete and undocumented simple checks 'service.ntp' and 'dns'.
(2) Obsoleted 'service.ntp' as a parameter to 'net.tcp.service' and 'net.tcp.service.perf'. Plain 'ntp' should be used instead, but 'service.ntp' is still supported.
(3) Check 'net.tcp.service.perf' did not work before for 'service.ntp'. This is fixed.
(4) Documentation said simple '_perf' checks return milliseconds, but they actually returned (and still do) fractional seconds. This is fixed.
(5) Added 'ldap', 'ldap_perf', 'ntp', and 'ntp_perf' simple checks. Internally, these are transformed into 'net.tcp.service' and 'net.tcp.service.perf', so if we wouldn't want them, it would actually take additional effort to forbid them.

And, of course, the original problem: 'port' parameter for 'tcp' and 'tcp_perf' is now mandatory.

Comment by Aleksandrs Saveljevs [ 2010 Jun 02 ]

Fixed in pre-1.8.3 in r12488.

Comment by Aleksandrs Saveljevs [ 2010 Jun 04 ]

Items net.tcp.service

{.perf}

no longer work when IP is omitted.

Comment by Aleksandrs Saveljevs [ 2010 Jun 04 ]

Fixed in pre-1.8.3 in r12567.

Comment by richlv [ 2010 Jun 04 ]

confirming the second fix in trunk rev 12568

Generated at Wed Apr 24 09:53:28 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.