[ZBX-2394] icmpping loss gets incorrect value 4294967196 Created: 2010 Apr 29  Updated: 2017 May 30  Resolved: 2010 Dec 27

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Server (S)
Affects Version/s: 1.8.2
Fix Version/s: 1.8.4

Type: Incident report Priority: Major
Reporter: Märt Laak Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

After upgrading from 1.8 to 1.8.2 i started to get icmpping loss values 4294967196 instead of normal percent

Unlsess I could not figure out the exact couse of the problem I found out that somehow pinger pings host twice and therefore actually gets 6 responses but code falsely assumes there were 3 pings so the value of loss percentage will be (3-6)/3*100 = 4294967196 (in unsigned)

I managed to fix it by adding new line 294 to libs/zbxicmpping/icmpping.c to reset the received packet counter:
293: c+= 3;
294+: host->rcv=0;
295:
296: do {

Please find out why it pingd two times in a row and does not reset the counter.

 Comments   
Comment by richlv [ 2010 Aug 25 ]

could it be that your fping is capable of pinging both ipv4 & ipv6 addresses ?

Comment by Märt Laak [ 2010 Aug 25 ]

Please suggest how to find this out (is fping capable of pinging both ipv4 & ipv6)?

Comment by richlv [ 2010 Aug 25 ]

something like this (on zabbix server as root)

for i in $(grep /fping /etc/zabbix/zabbix_server.conf | sed 's/^#[ ]*//'); do FPING=$(basename $i); $FPING 127.0.0.1 2>/dev/null; $FPING ::1 2>/dev/null; done

Comment by Märt Laak [ 2010 Aug 26 ]

Your script result is:
127.0.0.1 is alive
::1 is alive

BTW, yes we have both fping and fping6 lines in /etc/zabbix/zabbix_server.conf
FpingLocation=/usr/sbin/fping
Fping6Location=/usr/sbin/fping6

Is it not allowed? Same conf worked OK for version 1.8.

Comment by richlv [ 2010 Aug 26 ]

that means each fping only supports one address family, so it should work ok

edit : for the record, icmppingloss works just fine for me with no or 100% loss

Comment by richlv [ 2010 Sep 03 ]

not closely related issue, but one with icmp pings. with debuglevel4, sometimes empty lines are printed (and host data is empty - most likely that was supposed to go in the empty line) :

24310:20100902:164729.432 /tmp/zabbix_server_24310.pinger
24310:20100902:164729.432
24310:20100902:164729.432 /usr/sbin/fping -q -C3 2>&1 </tmp/zabbix_server_24310.pinger;/usr/sbin/fping6 -q -C3 2>&1 </tmp/zabbix_server_24310.pinger

Comment by Aleksandrs Saveljevs [ 2010 Dec 23 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-2394.

Comment by Aleksandrs Saveljevs [ 2010 Dec 27 ]

Merged into pre-1.8.4 in r16416.

Generated at Sat Apr 20 16:36:18 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.