[ZBX-2506] entries in dashboard group filter not sorted by node Created: 2010 Jun 04  Updated: 2017 May 30  Resolved: 2012 Jul 17

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.2rc1, 2.1.0

Type: Incident report Priority: Major
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: distributed, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

in the dashboard filter groups are not alphabetically sorted by node first, just by group name. instead, they should be filtered just like in the group selection popup - by node first, group name second.



 Comments   
Comment by Toms (Inactive) [ 2012 Jun 18 ]

Fixed in dev. branch: svn://svn.zabbix.com/branches/dev/ZBX-2506

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jun 21 ]

(1) Some problems with the doubleOrder() function:
1. we cannot define a class inside a function;
2. everywhere we define the sort order using the ZBX_SORT_UP and ZBX_SORT_DOWN constant, let's do the same here;
3. the sort class has no reason to use static properties and methods.

<Toms> RESOLVED in r28394. It turned out that we have a multisorting class, and ... it uses static methods

<pavels> It uses static method because the class was never meant to be instantiated, while your's was used as an object. CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jun 21 ]

(2) The sort order has to be fixed in the dashboard filter as well.

<Toms> RESOLVED in r28394

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jun 22 ]

I've improved the comment a bit in r28398, so we don't forget what exactly is wrong =)

TESTED.

Comment by Toms (Inactive) [ 2012 Jun 28 ]

Fixed in 2.1.0 r28483 and 2.0.2rc1 r28482

Comment by richlv [ 2012 Jul 16 ]

regression : extra colon is prefixed in dashboard filter for host groups in a non-dm setup

broken by :

------------------------------------------------------------------------
r28482 | tomtom | 2012-06-28 14:49:24 +0300 (Thu, 28 Jun 2012) | 1 line

..F....... ZBX-2506 fixed ordering for dashboard filter; fixed multisort function

Comment by Alexey Fukalov [ 2012 Jul 17 ]

dev branch: svn://svn.zabbix.com/branches/dev/ZBX-2506

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jul 17 ]

(1) The node name should be separated from the group name by a colon, but it shouldn't appear in a plain setup.

<Vedmak> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jul 17 ]

TESTED.

Comment by Alexey Fukalov [ 2012 Jul 17 ]

Fixed in pre-2.0.2rc1 r28956, and 2.1.0rc1 r28957

Comment by richlv [ 2012 Aug 01 ]

another regression : dashboard widgets are not sorted by host group anymore, added as ZBX-5396

Generated at Fri Apr 19 19:35:27 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.