[ZBX-2647] Translation correcting (hardcoded part of string) Created: 2010 Jul 04  Updated: 2017 May 30  Resolved: 2010 Dec 21

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.3
Fix Version/s: 1.9.1 (alpha)

Type: Incident report Priority: Minor
Reporter: Oleksii Zagorskyi Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

revision 13170


Attachments: PNG File 10.detail_report.png     PNG File 11.detail_report_2.png     PNG File 12.two_different_palaces.png     PNG File 5.untranslated_tip_statuses_of_trigger.png     PNG File 6.untraslated(attention-need_two_strings).png     PNG File 7.untranslated_in_web_sc.png     PNG File 8.untranslated_in_web_sc2.png     PNG File 9.trigger_statuses_TS_untranslatable.png     PNG File additional_untranslated.png     PNG File untranslate2.png     PNG File untranslated_hardcoded_part_of_string.png    

 Description   

text "(seconds)" in file \frontends\php\include\forms.inc.php is hardcoded. See screen shot.
Is bad....



 Comments   
Comment by Oleksii Zagorskyi [ 2010 Jul 05 ]

additional untranslated string discovered. see attached additional_untranslated.png

Comment by Oleksii Zagorskyi [ 2010 Jul 14 ]

Be careful - tip of trigger statuses stored into DB in 'triggers' table row 'error'
p.s. I still will add here pictures with not translated places. Do not hasten to resolve this issue. I will try to inform you in addition when I can already find nothing.

Comment by Oleksii Zagorskyi [ 2010 Sep 30 ]

no more suggestion. Now you can resolve this is issue.

Comment by Oleksii Zagorskyi [ 2010 Nov 24 ]

picture '5.untranslated_tip_statuses_of_trigger.png' is planed to resolve in the separate ZBXNEXT-567

Comment by Oleksii Zagorskyi [ 2010 Dec 17 ]

I checked dev/ZBX-2647 branch. I know that it can be not finished yet, but i want to report something.
info(S_ITEM_UNLINKED, $db_item["key_"]);
info(sprintf(S_TRIGGER_UNLINKED, $trigger['description']));
this is difference (sprintf using-not using) are normal ?

'S_CIRCULAR_LINK_CANNOT_BE_CREATED'=> 'Circular link can not be created'
is exist early.
need to remove new duplicate
'S_CIRCULAR_LINK_CANNOT' => 'Circular link can not be created',

At picture 12.two_different_palaces.png stay untranslated "Incorrect resource" text.
Stay untranslated 8. and 9. pictures.
Picture 9. is the duplicate of ZBX-2586 - don't forget to close it when fulfil this issue.

I must say that I have concentrated on the trunk version, and new strings for branche I will not have to translate. I will do so only in the trunk.
If you have done this a bit earlier, before gettextization - it would be great.
oh, i see an dev/ZBX-2647-trunk - don't worry

Comment by Aleksandrs Saveljevs [ 2010 Dec 17 ]

Unlike Oleksiy, I have not checked dev/ZBX-2647 branch yet, but in dev/dev-491 branch the message "Circular link cannot be created" also appears when I try to link template C to B, B to A, and C to A, which is wrong. Just FYI.

Comment by Konstantin Buravcov (Inactive) [ 2010 Dec 17 ]

Thank you, Oleksiy!

>info(S_ITEM_UNLINKED, $db_item["key_"]);
>info(sprintf(S_TRIGGER_UNLINKED, $trigger['description']));
You are right, I've corrected this place.

>S_CIRCULAR_LINK_CANNOT_BE_CREATED'=> 'Circular link can not be created' is exist early.
I've corrected this one too.

>At picture 12.two_different_palaces.png stay untranslated "Incorrect resource" text.
Seems, that in latest revision this string is changed to "Incorrect resource provided for screen item". It is translatable now.

Comment by Konstantin Buravcov (Inactive) [ 2010 Dec 20 ]

All provided cases and many more found on the way are marked for translations in trunk as well. It is possible, that there are more untranslated string in API exceptions, but I think they should be dealt with step by step.

Tip "Zabbix was restarted" (5.untranslated_tip_statuses_of_trigger.png) comes from Zabbix server and cannot be translated through frontend.

Comment by Oleksii Zagorskyi [ 2010 Dec 20 ]

Thank you for fulfilling this request. In return I promise that I will make Ukrainian and help with Russian translation for the 1.8 branch. This is a token of my gratitude to you.

About picture (5.untranslated_tip_statuses_of_trigger.png) as we discussed with Richlv - it can be translated and for this i registered separate ZBXNEXT-567. The same partially for picture (8.untranslated_in_web_sc2.png) - "page didn't match"

Some details of this issue I will add to the others.
Let's close this issue, and if i find the remarks - we will deal with them separately.

Comment by Oleksii Zagorskyi [ 2010 Dec 21 ]

For trunk version it seems you forgot to include modified files to POTFILES.in

Comment by richlv [ 2010 Dec 21 ]

thanks for the note. now all php files will be scanned for translatable strings

Comment by Konstantin Buravcov (Inactive) [ 2010 Dec 21 ]

Merged to branches/1.8: 16294
Merged to trunk: 16298

Generated at Fri Apr 18 01:52:09 EEST 2025 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.