screenshot-1.jpg
zabbix-1.8.3-default_period.patch
|
Duplicate |
[ZBX-2885] 00:00-23:59 vs. 00:00-24:00 inconsistency for periods Created: 2010 Aug 16 Updated: 2017 May 30 Resolved: 2012 May 08 |
|
| Status: | Closed |
| Project: | ZABBIX BUGS AND ISSUES |
| Component/s: | Frontend (F), Server (S) |
| Affects Version/s: | 1.8.3rc4 |
| Fix Version/s: | 1.9.4 (alpha) |
| Type: | Incident report | Priority: | Major |
| Reporter: | Aleksandrs Saveljevs | Assignee: | dimir |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
screenshot-1.jpg
zabbix-1.8.3-default_period.patch
|
||||
| Issue Links: |
|
||||
| Description |
|
We have an inconsistency in DB schema, server, and frontend as to how 24-hour specification should be done. For instance, table "media" has the following specification for field "period": period varchar(100) DEFAULT '1-7,00:00-23:59' NOT NULL At the same time, table "config" specifies the following for "work_period": work_period varchar(100) DEFAULT '1-5,00:00-24:00' NOT NULL The default values for periods as offered by the frontend are "1-7,00:00-23:59". We think that 00:00-24:00 everywhere would be more correct and more intuitive. |
| Comments |
| Comment by Kodai Terashima [ 2010 Aug 25 ] |
|
I set "1-7,00:00-23:59" in user's media screen, notification mail is not sent during 23:59 to 24:00. I think default period setting should be "1-7,00:00-24:00". |
| Comment by richlv [ 2010 Aug 25 ] |
|
not sending the message sounds serious enough... time format should be unified & defaults changed accordingly |
| Comment by dimir [ 2011 Apr 14 ] |
|
00-24:00 looks bad IMHO. Why not instead fix the thing that processes that period instead? In my understanding 23:59 without specifying seconds means any seconds, in other words: 23:59:00 - 23:59:59.9999999999999999... So, as I see it if user sets period "00:00-23:59" then something happening at 23:59:23 is in the period. Otherwise it means that 23:59 means 23:59:00 and not 23:59:01 which looks plain wrong to me. |
| Comment by richlv [ 2011 Apr 14 ] |
|
what about 00:00-00:01 ? it would be highly unintuitive for that to mean > 00:00 but < 00:02 |
| Comment by Aleksandrs Saveljevs [ 2011 Apr 15 ] |
|
First, changing the behavior would break existing installations. For instance, one of the recent reporters had items configured with a flexible interval "60 sec at 7,19:30-19:31", which executed a check one per week. Second, as Rich pointed out, it is probably more intuitive to specify 9 AM till 6 PM on weekdays as "1-5,09:00-18:00", not "1-5,09:00-17:59". |
| Comment by dimir [ 2011 Apr 15 ] |
|
OK, thanks for clearing it out. |
| Comment by dimir [ 2011 Apr 27 ] |
|
Fixed in version 1.9.4, r19117. |
| Comment by Oleksii Zagorskyi [ 2012 May 07 ] |
|
Reopened to set "Fix version/s" correctly |
| Comment by Oleksii Zagorskyi [ 2012 May 08 ] |
|
Closed again |