[ZBX-3001] polish editing of medias Created: 2010 Sep 14  Updated: 2017 May 30  Resolved: 2012 Jun 29

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.3
Fix Version/s: 2.0.2rc1, 2.1.0

Type: Incident report Priority: Minor
Reporter: Aleksandrs Saveljevs Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: media, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File action-config-1.png     PNG File action-config-2.png     PNG File defined-medias.png     PNG File medias-in-profile.png    

 Description   

(1) In user's profile, medias are sorted by ID (see medias-in-profile.png). It would probably be better to sort them by type.

(2) Suppose we have two medias, one email and one SMS, defined as shown in defined-medias.png. We also have an action (see action-config-1.png) that uses our email media. We then disable our email media, go back to action configuration, and see action-config-2.png. It says "send to all" and "no medias defined", which is false and misleading, because we also have SMS media enabled. It would probably be better to say something like "sent to email" and "no medias defined or enabled" instead.

Note that same thing happens when deleting a media for which an action is defined. Something might or might not be done about it in 2.0 under database integrity changes. However, the issue will still remain with disabled medias, so let us do something about it.



 Comments   
Comment by Alexander Vladishev [ 2012 Jun 18 ]

2nd already fixed in 2.0.0

Comment by Alexey Fukalov [ 2012 Jun 27 ]

dev branch: svn://svn.zabbix.com/branches/dev/ZBX-3001

Comment by Toms (Inactive) [ 2012 Jun 29 ]

(1) In forms.inc.php where you changed the code you could change other variables to new guidelines as well.

<Vedmak> RESOLVED

<Toms> CLOSED

Comment by Toms (Inactive) [ 2012 Jun 29 ]

(2) for
while ($db_media_type = DBfetch($db_media_types))

{ $mediaTypeDescriptions[$db_media_type['mediatypeid']] = $db_media_type['description']; }

in forms.inc.php
there is function DBfetchArrayAssoc($cursor, $field)
You can use it with little change to following code;

<Vedmak> DBfetchArrayAssoc return array with full rows, there only 'description' is needed.

<Toms> There is only extra id, so you can use the row and later assign description

<Toms> CLOSED

Comment by Toms (Inactive) [ 2012 Jun 29 ]

TESTED

Comment by Alexey Fukalov [ 2012 Jun 29 ]

Fixed in pre-2.0.2rc1 r28562, pre-2.1.0 r28563

Generated at Tue Apr 23 16:56:02 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.