[ZBX-3236] Value maps for character item type not working anymore Created: 2010 Nov 24  Updated: 2017 May 30  Resolved: 2013 Feb 01

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.3
Fix Version/s: 2.1.0

Type: Incident report Priority: Major
Reporter: Alixen Assignee: Martins Valkovskis
Resolution: Fixed Votes: 1
Labels: regression, valuemapping
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by ZBXNEXT-339 Would be nice to allow value mapping ... Closed

 Description   

In Zabbix 1.6, I have configured value maps for "Character" items. They are still working in Zabbix 1.8.
However, it is not possible anymore to create a character item with a value map since this field is removed from GUI entry form.

I was able to associate a value map to a character by modifying it directly in database:
mysql> update items set valuemapid=13 where description = 'my item description';
After that, value maps are correctly displayed in Latest Data page.

PS: This bug is similar to ZBXNEXT-339. I have opened a new bug since it is currently a regression from 1.6 behavior.



 Comments   
Comment by Alexey Fukalov [ 2012 Sep 18 ]

Frontend part implemented in svn://svn.zabbix.com/branches/dev/ZBX-3236

Comment by Toms (Inactive) [ 2012 Sep 19 ]

TESTED

Comment by Alexander Vladishev [ 2012 Sep 20 ]

I'm reopen the issue. Server side isn't implemented.

Comment by Alexander Vladishev [ 2012 Sep 24 ]

(1) [F] Value mapping doesn't work in the "Latest data" screen if its length more than 20 characters. The same problem with macros

{ITEM.VALUE}

Vedmak RESOLVED

<Toms> When shortening missing closing parenthesis: "bbb (aaaaaaaaaaaaaaa ..."

When long mapped value, impossible to see that it is mapped: "bbbeeeeeeeeeeeeeeeee ..."

As we decided: don't shorten mapped value, but actual value in parenthesis has maximal length of 20 characters

Vedmak RESOLVED

tomtom CLOSED.

It would be nice to write revision Nr. on each RESOLVED, it is especially important in larger issues.

Comment by Alexander Vladishev [ 2012 Sep 24 ]

svn://svn.zabbix.com/branches/dev/ZBX-3236 r30307:30309 (only stylistic changes). Server side works fine for character items without any changes.

Successfully tested by me.

Comment by richlv [ 2012 Sep 26 ]

just a note : initial frontend implementation had a typo in issue name, so grep might fail :

r30263 | vedmak | 2012-09-18 16:26:25 +0300 (Tue, 18 Sep 2012) | 1 line

..F....... ZBX-3226 made value maps available for character items in frontend

Comment by richlv [ 2012 Sep 26 ]

(2) quick look at the diffs seems to indicate that this was added for character type, but not for text type (no objections to that ) - is that correct ?
hmm, apparently valmaps for floats were implemented in this issue as well ?
or was just validation for them changed in valmap config ?
seriously, guys, how could anybody document anything about this issue. i'm trying to compare trunk against the dev branch, and, well, it's pain.

dealing with (4) should fix this item

also, if ints, floats and chars all work now (and we decide not to do that for text & log), that should fulfill ZBXNEXT-339

Vedmak Rich, in this issue there was added value map support for character item types, as noted in issue name, everything else should be considered as bug. For frontend part i didn't change anything related to floats. Is there any bugs with this issue? If it's not understandable what functionality current bug changes imo blame absence of specs.

<richlv> i tried to map "1.6 -> a" in trunk - is not allowed. is allowed in this dev branch
didn't try whether it works in frontend & server, though

Vedmak how to distinct float number 1.6 and string 1.6?

<richlv>
a) it could still be impossible to select value mapping for float items, server could still not work with such items (checking by item type) etc
b) even if we ignore (a), we should look at this from the user perspective when documenting effective changes - if the side effect of allowing strings was allowing floats, it should be mentioned

Vedmak ok, floats work too, user should be happy not working only with log and text.

<richv> great, added that bit to whatsnew mentioned in (3) -> CLOSED

Comment by richlv [ 2012 Sep 26 ]

(3) documented at http://www.zabbix.com/documentation/2.2/manual/introduction/whatsnew220#value_mapping_for_string_type_data
this should also be documented in corresponding 2.2 manual page (still to be created)

zalex_ua Maybe we could create a separate doc page where collect links to issues which later have to be reflected in 2.2 documentation ?

<richlv> sounds risky. we'll miss things, and we'll have huge amount of work just prior to release. it also doesn't match "keep everything ready for release any time".
better - let's create and document everything right away.

martins-v Reflected in the value mapping documentation page:

https://www.zabbix.com/documentation/2.2/manual/config/items/mapping

sasha Please fix:

Before:
Before Zabbix 2.2 value mapping could only be used with items having a Numeric (unsigned) type of information. Starting with Zabbix 2.2, Numeric (float) and Character information types are also supported for value mapping.

To:
Before Zabbix 2.2 value mapping could only be used with items having a Numeric (unsigned) and Numeric (float) information types. Starting with Zabbix 2.2, Character type of information are also supported for value mapping.

martins-v Note fixed.
-----------------------------------

Also:
Now, value mapping works for character values too. For example:

a -> Up
b -> Down

will be represented as:

Up (a)
Down (b)

<richlv> seems ok to me, CLOSED

Comment by richlv [ 2012 Sep 26 ]

(4) apparently, hint & tooltip were removed ? that's kinda ok, but let's have two things...
a) full list of changes;
b) list of translation strings changed/removed

Vedmak
a) Value maps for character item type now working. value maps can be created for string values.
b) let's first agree with all that we will do such thing. For this issue afair none were changed.

<richlv>
a) see (2) - what about floats ?
b) what about hint text (in the field), tooltip and validation error message ?

Vedmak b) ye, validation messages are removed. What do you need list of changed translations for?

<richlv> as discussed, we clarified that there were no additional functional changes -> CLOSED

Comment by Alexey Fukalov [ 2012 Sep 28 ]

Fixed in pre-2.1.0 r30412

Comment by richlv [ 2012 Sep 28 ]

let's deal with (3) fully

Comment by richlv [ 2012 Oct 08 ]

this seems to have caused a regression : ZBX-5670

Generated at Tue Apr 23 16:31:20 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.