[ZBX-3503] Function item_description must be rewritten Created: 2011 Feb 04  Updated: 2017 May 30  Resolved: 2011 Apr 18

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Incident report Priority: Minor
Reporter: Konstantin Buravcov (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File legend_nbsp.png    

 Description   

Function item_description logic is outdated. It should be rewritten to use new trigger expression parser.

 Comments   
Comment by Aleksandrs Saveljevs [ 2011 Mar 18 ]

Related issue: ZBX-3251.

Comment by Konstantin Buravcov (Inactive) [ 2011 Mar 30 ]

Done in dev branch ZBX-3503

Comment by Konstantin Buravcov (Inactive) [ 2011 Apr 06 ]

I have added funtion that parses item key to ZBX-3503-trunk branch. I would like to ask testers to take a look at test cases in ZBX-3503-trunk/frontends/php/tests/general/function_parseItemKey.php and check if expected results match the expected behavour.

Also, feel free to add your own test cases. To run this test:
phpunit --bootstrap=/var/www/dev/bootstrap.php general/function_parseItemKey.php

Comment by Konstantin Buravcov (Inactive) [ 2011 Apr 12 ]

Merged to trunk revision 19008
Still needs to merged to 1.8 when it won't be locked anymore.

Comment by richlv [ 2011 Apr 14 ]

this turned all spaces in graph item legend into " "...

Comment by Alexei Vladishev [ 2011 Apr 15 ]

>this turned all spaces in graph item legend into " "...

Rich, you forgot your favourite prefix, WTF! I am seriously scared about any re-factoring lately, normally we fix one thing and break a dozen of others...

Comment by Konstantin Buravcov (Inactive) [ 2011 Apr 15 ]

richlv, I connot reproduce it - I see normal spaces. You mean you literaly see " "? Can you provide screenshot or steps to reproduce?

Comment by richlv [ 2011 Apr 15 ]

see the attachment. or even live at https://zabbix.org/zabbix/history.php?action=showgraph&itemid=7

Comment by Brad [ 2011 Apr 18 ]

I have 2 different installs, one based on CentOS 5.5 and one CentOS 5.6

PHP versions:
C5.5 = 5.1.6
C5.6 = 5.3.3

Both exhibit the   failure talked about above.

Comment by Konstantin Buravcov (Inactive) [ 2011 Apr 18 ]

I have reverted the   related stuff in trunk rev 19062. It seems, that PHP GD behaves differently across different instalations.

Let's leave spaces for ZBX-3602

Comment by Konstantin Buravcov (Inactive) [ 2011 Apr 20 ]

Merged to 1.8 rev 19123

Generated at Sat Apr 20 05:06:37 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.