CentOS 5, PostgreSQL 8.4, Firefox 3.0.19

Related issue ZBX-3499

RESOLVED for trunk in svn://svn.zabbix.com/branches/dev/ZBX-3721.

I've fixed these issues in all or some of the themes:

• the color of the text in trigger severities;
• host menu item color and link color;
• the highlighted line in some of the forms;
• improved the filter design;
• text color in the new warning messages;
• the layout of the setup when opening it from the frontend.

Additionally, I've reorganized the css files a bit.

Before testing, be sure to apply the DB patches.

(1)
In schema users table "default.css" left.

<pavels> RESOLVED.

<Vedmak> CLOSED

(2)
In host form, when start interface drag, messages "drag interface here..." are placed too far from "add" button if there is no interfaces of that type.

<pavels> RESOLVED. Also I've changed the design of the drag'n'drop interface a bit.

<Vedmak> CLOSED

(3) in hosts filter, item filter, maybe somewhere else, some table cells have solid border line while most have dotted.

<pavels> That's a browser rendering problems. Changed the border style to solid to fix it. RESOLVED.

<Vedmak> CLOSED

(4)
I think we can leave em's in host edit for for interface tables.

<pavels> RESOLVED.

<Vedmak> CLOSED

(5)
In darkorange theme there is something wrong with "Connect to" radio buttons.

Seems not only in that form.

<pavels> What about them?

<pavels> CLOSED.

<Vedmak> CLOSED

(6)
Graph images don't use dark colors in "darkblue" theme.

<pavels> I've added the "Dark orange" theme to data.tmpl. RESOLVED.

<Vedmak> CLOSED

(7)
Items filter looks bad when browser window width is 1024.

<pavels> RESOLVED.

<Vedmak> CLOSED

(8) There are no patches for graph_theme.sql

<pavels> RESOLVED.

<Vedmak> probably patch for new record in table graph_theme is needed also.

<pavels> RESOLVED.

<Vedmak> graphthemeid must be inserted too.

<pavels> RESOLVED.

<richlv> looks like most of the patches lack the trailing newline

<pavels> RESOLVED.

<Vedmak> CLOSED

(9) Also, please review the issues from ZBX-2873. RESOLVED.

<Vedmak> CLOSED

(10) Probably API examples should be reviewed before closing the issue:
http://www.zabbix.com/documentation/2.0/manual/appendix/api/user/create
http://www.zabbix.com/documentation/2.0/manual/appendix/api/user/get
http://www.zabbix.com/documentation/2.0/manual/appendix/api/user/updateprofile
http://www.zabbix.com/documentation/2.0/manual/appendix/api/user/definitions <- would be good to describe possible variants for "theme"

please update the "lang" as well : en_gb -> en_GB
because of implemented gettext

<pavels> I'll do that right after I merge the changes to the trunk.

<pavels> RESOLVED.

<zalex> in the http://www.zabbix.com/documentation/2.0/manual/appendix/api/user/create
I've added escaping for quoted values inside message - we should show it "as is", without modifications, as users will see it.
CLOSED

(11) The "Theming" section of the 2.0 docs should also be updated.

<pavels> http://www.zabbix.com/documentation/2.0/manual/web_interface/theming/creating_your_own_theme RESOLVED.

<pavels> Closing with Martin's blessing. CLOSED.

(12) In r26650 I've changed the way themes are defined, please review.

<Vedmak> CLOSED

(13) In r26652 I've changed the color of input fields in the darkblue theme.

<Sasha> Great! CLOSED

(14) Drop down and simple lists are aligned incorrectly in Dark orange and Black and blue themes

<pavels> RESOLVED.
<Sasha> Dark Orange CLOSED
<Sasha> Black&Blue REOPENED

<pavels> RESOLVED.
<Sasha> CLOSED

(15) Height of a header bar is different in Original Blue and Dark orange or Black and blue themes

<pavels> RESOLVED.

<Vedmak> CLOSED

(16) Some links are not underlined in Dark orange and Black and blue themes

<pavels> RESOLVED.

<Vedmak> CLOSED

(17)
In black&blue, dropdowns text is not readable

<pavels> RESOLVED.

<Vedmak> CLOSED

Available in trunk r26859. Don't forget to patch the DB.

(18) Sorry, I don't see in the upgrade patches modifications of existing DB schema.
I mean a statement like:
ALTER TABLE users MODIFY theme VARCHAR(128) NOT NULL DEFAULT 'default';

Btw, the patch "users.sql" could be rewritten to perform single "ALTER TABLE" and several MODIFY, as it done for most patches already.
REOPENED

<pavels> RESOLVED in the dev branch.

<pavels> CLOSED.

(19) grapththemeid

<pavels> Fixed directly in trunk. CLOSED.

CLOSED.

this slightly broke search results : ZBX-5253