[ZBX-3725] Need to show error message after importing xml file if in the php.ini conf file there is configured not enough memory Created: 2011 Apr 14 Updated: 2017 May 30 Resolved: 2012 Mar 28 |
|
| Status: | Closed |
| Project: | ZABBIX BUGS AND ISSUES |
| Component/s: | Frontend (F) |
| Affects Version/s: | 1.8.5rc1 |
| Fix Version/s: | 2.0.0rc3 |
| Type: | Incident report | Priority: | Critical |
| Reporter: | Igor Danoshaites (Inactive) | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | xml | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Description |
|
When in the php.ini conf file there is configured not enough memory (parameters "upload_max_filesize" and/or "post_max_size") xml file will not be imported, BUT on the screen also will not appear any error message. This is very confusing, we should show some error message in this case. |
| Comments |
| Comment by richlv [ 2011 Apr 14 ] |
|
we could also query max upload filesize and show that next to all upload fields (all xml fields, image fields etc). |
| Comment by richlv [ 2012 Mar 19 ] |
|
this problem still present in trunk rev 26172. |
| Comment by Alexey Fukalov [ 2012 Mar 26 ] |
|
dev branch: svn://svn.zabbix.com/branches/dev/ZBX-3725 |
| Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 26 ] |
|
As far as I know, when PHP runs out of memory, it will often exit unexpectedly. We can't rely on it to display an error message. |
| Comment by Alexey Fukalov [ 2012 Mar 26 ] |
|
I added check only for import file size and upload_max_filesize. PHP out of memory is another thing not related to import directly, though i think we can catch and display it with shutdown function. <pavels> Ah, sorry, I thought you were talking about memory_limit. I think the shutdown function is not reliable when it comes to reaching the memory limit. |
| Comment by Toms (Inactive) [ 2012 Mar 28 ] |
|
(1) Review my changes in r26453 <Vedmak> CLOSED i changed comment to php doc style |
| Comment by Toms (Inactive) [ 2012 Mar 28 ] |
|
(2) It is possible to upload non image file in adm.images.php <Vedmak> I think it's separate issue, this one only about reaching max_upload_filesize. Probably new issue can be created for uploading non-image files. <Toms> As separate as changing adm.images.php at all, I think. CLOSED |
| Comment by Alexey Fukalov [ 2012 Mar 30 ] |
|
svn://svn.zabbix.com/trunk 26495 |