[ZBX-3853] Errors in strings and its inconsistency. Created: 2011 Jun 01  Updated: 2017 May 30  Resolved: 2012 Jun 25

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.2rc1, 2.1.0

Type: Incident report Priority: Major
Reporter: Oleksii Zagorskyi Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: localization
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

latest trunk of course

Issue Links:
Duplicate
duplicates ZBX-3759 Incorrect GUI (API) string Closed

 Description   

During translation i found several "bugs"

/php/api/classes/class.cgraphprototype.php:651
/php/api/classes/class.cgraph.php:657
self::exception(ZBX_API_ERROR_PARAMETERS, S_GRAPH.' [ '.$graph['name'].' ] '.S_GRAPH_TEMPLATE_HOST_CANNOT_OTHER_ITEMS_HOSTS_SMALL);

include/locales/en_gb.inc.php:1865
'S_GRAPH_TEMPLATE_HOST_CANNOT_OTHER_ITEMS_HOSTS_SMALL'=>_('with template host cannot contain items from other hosts.'),

Question to developers: how translator can translate correctly this string?
This string even contains logical error, i think this is right: "with templated items cannot contain items from other hosts."
Proof - http://www.zabbix.com/documentation/1.8/manual/config/graphs
And after it should be combined to single string like a "Graph %s with templated items cannot contain items from other hosts." or so.

api/classes/class.citemgeneral.php:226
Value type must be Float for aggregate items.
this string contain inconsistency "Value type" <-> "Type of information"
I propose to fix it and even improve: "Type of information must be "Numeric (float)" for aggregate items.

api/classes/class.citemgeneral.php:222
Type of information must be Log for log key.
I propose : Type of information must be "Log" for log key.

"Zabbix %s Copyright 2001-2011 by Zabbix SIA"
I propose to replace years date to some variable, then translators should not alter this string every year.

 Comments   
Comment by Aleksandrs Saveljevs [ 2011 Sep 26 ]

Source code is copyrighted from 2000 till 2011, but the frontend says from 2001 till 2011. When doing the last thing proposed by Oleksiy, we might wish to change the frontend's message to 2000 as well.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jun 25 ]

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-3853.

Comment by Oleksii Zagorskyi [ 2012 Jun 25 ]

(1) As noted in the issue description, replace please:
Value type must be "Numeric (float)" for aggregate items.
to:
Type of information must be "Numeric (float)" for aggregate items.

<pavels> RESOLVED.

<zalex> CLOSED

Comment by Oleksii Zagorskyi [ 2012 Jun 25 ]

(2) No answer to my first note (about the logical error) in issue description.
Please find in the sources this part of a string:
with template host cannot contain items from other hosts

I still suggest to change it to:
with templated items cannot contain items from other hosts.

REOPENED

<pavels> RESOLVED.

<zalex> Thanks, CLOSED

Comment by Eduards Samersovs (Inactive) [ 2012 Jun 26 ]

Tested

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jun 28 ]

Fixed in 2.0 r28497 and trunk 28498.

CLOSED.

Generated at Tue Apr 23 16:07:33 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.